Bug 780504 – lokview: Add pre-OOXML MS Office formats

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 780504 - lokview: Add pre-OOXML MS Office formats


Summary:	lokview: Add pre-OOXML MS Office formats


Status:	RESOLVED FIXED

Product:	gnome-documents
Classification:	Core
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME documents maintainer(s)
QA Contact:	GNOME documents maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-03-24 16:14 UTC by Pranav Kant
Modified:	2017-03-24 16:55 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
lokview: Add old MSO formats (2.15 KB, patch) 2017-03-24 16:14 UTC, Pranav Kant	accepted-commit_now	Details \| Review
lokview: Add pre-OOXML MS Office formats (2.09 KB, patch) 2017-03-24 16:32 UTC, Pranav Kant	none	Details \| Review
lokview: Add pre-OOXML MS Office formats (2.04 KB, patch) 2017-03-24 16:33 UTC, Pranav Kant	committed	Details \| Review

Description Pranav Kant 2017-03-24 16:14:45 UTC

Since LOKDocView widget can support opening these formats, why
not use it.

Comment 1 Pranav Kant 2017-03-24 16:14:51 UTC

Created attachment 348658 [details] [review]
lokview: Add old MSO formats

Comment 2 Debarshi Ray 2017-03-24 16:27:10 UTC

Review of attachment 348658 [details] [review]:

Thanks, Pranav! Looks good to me. Maybe expand "MSO" to "MS Office" so that it's a bit more obvious? :)

::: src/lokview.js
@@ +65,3 @@
+                             'application/msword',
+                             'application/vnd.ms-excel',
+                             'application/vnd.ms-powerpoint',

Nitpick: could you please move them up to retain the alphabetical ordering?

@@ +80,3 @@
+                                 'application/vnd.openxmlformats-officedocument.spreadsheetml.template',
+                                 'application/vnd.ms-excel',
+                                 'application/vnd.ms-powerpoint',

Ditto.

Comment 3 Pranav Kant 2017-03-24 16:32:28 UTC

Created attachment 348661 [details] [review]
lokview: Add pre-OOXML MS Office formats

https://bugzilla.gnome.org/show_bug.cgi?id=780504

https://bugzilla.gnome.org/show_bug.cgi?id=661593

Comment 4 Pranav Kant 2017-03-24 16:33:17 UTC

Created attachment 348662 [details] [review]
lokview: Add pre-OOXML MS Office formats

Comment 5 Pranav Kant 2017-03-24 16:43:14 UTC

master 9d4b811