GNOME Bugzilla – Bug 780460
Untranslatable strings
Last modified: 2017-03-23 20:09:01 UTC
“Bookmark Properties” in src/bookmarks/ephy-bookmark-row.c is not marked for translation. Also clicking the bookmarks button on the header bar → Tags → Favorites shows “Favorites” header in English.
The following fix has been pushed: 2ad3d63 Mark Bookmark Properties string for translation
Created attachment 348588 [details] [review] Mark Bookmark Properties string for translation Oops
Strings from src/clear-data-dialog.c are also in English.
Created attachment 348589 [details] [review] Attempt to fix translation of Favorites string This is untested. Piotr, do you have time to try testing this?
I can’t, sorry!
Another case is strings in lib/ephy-form-auth-data.c, visible in Seahorse.
(In reply to Piotr Drąg from comment #6) > Another case is strings in lib/ephy-form-auth-data.c, visible in Seahorse. Which strings specifically? I don't see anything there than can be translated. E.g. we cannot translate schema keys.
The following fix has been pushed: 99827b5 Fix untranslated strings in clear data dialog
Created attachment 348600 [details] [review] Fix untranslated strings in clear data dialog
(In reply to Michael Catanzaro from comment #7) > (In reply to Piotr Drąg from comment #6) > > Another case is strings in lib/ephy-form-auth-data.c, visible in Seahorse. > > Which strings specifically? I don't see anything there than can be > translated. E.g. we cannot translate schema keys. “Password for %s in a form in %s” and “Password in a form in %s”. Similar strings from GOA (<https://git.gnome.org/browse/gnome-online-accounts/tree/src/goabackend/goautils.c#n508>) are shown translated in Seahorse.
The following fix has been pushed: 71568c3 Fix untranslated Favorites string in bookmarks popover title
Created attachment 348602 [details] [review] Fix untranslated Favorites string in bookmarks popover title We translated it in most places, but missed a spot.
(In reply to Piotr Drąg from comment #10) > “Password for %s in a form in %s” and “Password in a form in %s”. Similar > strings from GOA > (<https://git.gnome.org/browse/gnome-online-accounts/tree/src/goabackend/ > goautils.c#n508>) are shown translated in Seahorse. OK but these are both actually marked for translation, and ephy-form-auth-data.c is present in POTFILES.in.
(In reply to Michael Catanzaro from comment #13) > OK but these are both actually marked for translation, and > ephy-form-auth-data.c is present in POTFILES.in. Right, so it’s different. Would you like me to file a new bug for it?
(In reply to Piotr Drąg from comment #14) > (In reply to Michael Catanzaro from comment #13) > > OK but these are both actually marked for translation, and > > ephy-form-auth-data.c is present in POTFILES.in. > > Right, so it’s different. Would you like me to file a new bug for it? Yeah, thanks. But I have no clue what's going on, so somebody is going to have to debug it for it to be fixed. :( But you got lots of other untranslatable strings fixed, so that's good!
(In reply to Michael Catanzaro from comment #15) > Yeah, thanks. But I have no clue what's going on, so somebody is going to > have to debug it for it to be fixed. :( > Reported as bug #780476. > But you got lots of other untranslatable strings fixed, so that's good! *We* did that. :)