After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780458 - Missing strings in WebKitGTK+
Missing strings in WebKitGTK+
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-23 16:21 UTC by Piotr Drąg
Modified: 2017-04-25 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Piotr Drąg 2017-03-23 16:21:53 UTC
After <https://bugs.webkit.org/show_bug.cgi?id=169672>, many strings are missing from the .pot file at <https://l10n.gnome.org/module/webkit/>. It looks like d-l doesn’t extract strings marked with WEB_UI_STRING* (<https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/gtk/po/CMakeLists.txt#L19>.
Comment 1 Claude Paroz 2017-03-23 16:52:46 UTC
D-L reads any XGETTEXT_OPTIONS located in po/Makevars files.
https://www.gnu.org/software/gettext/manual/html_node/po_002fMakevars.html#po_002fMakevars
Comment 2 Piotr Drąg 2017-03-23 18:10:06 UTC
Does it include projects using intltool, like WebKitGTK+?
Comment 3 Claude Paroz 2017-03-23 18:21:59 UTC
Ah, no, this was for pure gettext extraction method. So I'm afraid this is an intltool/WebKitGTK+ issue, so nothing that we can do.
Comment 4 Piotr Drąg 2017-03-23 18:26:32 UTC
WebKitGTK+ itself doesn’t use intltool, but rather CMake — https://svn.webkit.org/repository/webkit/trunk/Source/WebCore/platform/gtk/po/ — maybe we could switch it to gettext on d-l side if they add po/Makevars?
Comment 5 Piotr Drąg 2017-04-25 18:44:31 UTC
After adding po/Makevars in https://bugs.webkit.org/show_bug.cgi?id=170012, damned-lies correctly extracts all the strings, including WEB_UI_STRING*.
Comment 6 Claude Paroz 2017-04-25 19:29:30 UTC
Nice job, thanks!