After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780452 - gnome-chess: Drop use of G_MODULE_EXPORT
gnome-chess: Drop use of G_MODULE_EXPORT
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-23 15:31 UTC by Philip Withnall
Modified: 2017-03-23 19:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-chess: Drop use of G_MODULE_EXPORT (8.20 KB, patch)
2017-03-23 15:31 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2017-03-23 15:31:50 UTC 
This fixes the build with GLib 553329358c9e6845d567bb7367ae404c21d22dea: see http://build.gnome.org/continuous/buildmaster/builds/2017/03/23/37/build/log-gnome-chess.txt.
Comment 1 Philip Withnall 2017-03-23 15:31:53 UTC 
Created attachment 348580 [details] [review]
gnome-chess: Drop use of G_MODULE_EXPORT

The usage was incorrect: it resulted in G_MODULE_EXPORT being added to
all function *calls* to these functions, as well as the function
declarations and definitions. Now that G_MODULE_EXPORT is defined as
non-empty on Linux, the build fails.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Philip Withnall 2017-03-23 16:35:17 UTC 
Attachment 348580 [details] pushed as 21b0df6 - gnome-chess: Drop use of G_MODULE_EXPORT
Comment 3 Sahil Sareen 2017-03-23 19:50:24 UTC 
Thanks for taking the time to fix this Philip!