After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780402 - ttml: Correctly render blocks containing text of multiple sizes
ttml: Correctly render blocks containing text of multiple sizes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-22 14:22 UTC by Chris Bass
Modified: 2017-04-09 07:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
TTML file demonstrating the problem (1.27 KB, text/xml)
2017-03-22 14:24 UTC, Chris Bass
  Details
ttmlrender: put all functions in gst_ttml_render namespace (3.99 KB, patch)
2017-03-22 14:36 UTC, Chris Bass
committed Details | Review
ttmlrender: store PangoLayout in object state (5.55 KB, patch)
2017-03-22 14:37 UTC, Chris Bass
committed Details | Review
ttmlrender: rename TextRange type and its fields (4.66 KB, patch)
2017-03-22 14:37 UTC, Chris Bass
committed Details | Review
ttml: add refcounting to GstSubtitleStlyeSet type (5.55 KB, patch)
2017-03-22 14:38 UTC, Chris Bass
committed Details | Review
ttmlrender: extend UnifiedBlock type (2.44 KB, patch)
2017-03-22 14:39 UTC, Chris Bass
committed Details | Review
ttmlrender: extend UnifiedElement type to include font metrics (6.12 KB, patch)
2017-03-22 14:39 UTC, Chris Bass
committed Details | Review
ttmlrender: add facility to stitch images in both directions (5.36 KB, patch)
2017-03-22 14:40 UTC, Chris Bass
committed Details | Review
ttmlrender: apply correct line height to blocks with multiple text sizes (49.56 KB, patch)
2017-03-22 14:40 UTC, Chris Bass
committed Details | Review
ttml: correctly implement lineHeight behaviour (4.47 KB, patch)
2017-03-22 14:41 UTC, Chris Bass
committed Details | Review
ttmlrender: relocate type definitions to head of file (2.31 KB, patch)
2017-03-22 14:42 UTC, Chris Bass
committed Details | Review
ttmlrender: improve function comments/descriptions (1.96 KB, patch)
2017-03-22 14:42 UTC, Chris Bass
committed Details | Review
ttmlparse: don't leak caps (731 bytes, patch)
2017-03-22 14:43 UTC, Chris Bass
committed Details | Review

Description Chris Bass 2017-03-22 14:22:53 UTC
The ttml plugin doesn't correctly handle subtitle blocks that contain elements with different text sizes. This manifests itself as a varying baseline separation between lines of text, with the result that text is incorrectly position with respect to its background rectangles.

Patchset to follow...
Comment 1 Chris Bass 2017-03-22 14:24:32 UTC
Created attachment 348493 [details]
TTML file demonstrating the problem

The attached file demonstrates the problem. It can be presented by running the following command:

gst-launch-1.0 ttmlrender name=r videotestsrc pattern="gradient" ! video/x-raw,width=1280,height=720 ! autovideoconvert ! r.video_sink filesrc blocksize=16777216 location=line-height-test.xml ! ttmlparse ! r.text_sink r. ! ximagesink
Comment 2 Chris Bass 2017-03-22 14:36:51 UTC
Created attachment 348495 [details] [review]
ttmlrender: put all functions in gst_ttml_render  namespace
Comment 3 Chris Bass 2017-03-22 14:37:21 UTC
Created attachment 348496 [details] [review]
ttmlrender: store PangoLayout in object state
Comment 4 Chris Bass 2017-03-22 14:37:56 UTC
Created attachment 348497 [details] [review]
ttmlrender: rename TextRange type and its fields
Comment 5 Chris Bass 2017-03-22 14:38:38 UTC
Created attachment 348498 [details] [review]
ttml: add refcounting to GstSubtitleStlyeSet type
Comment 6 Chris Bass 2017-03-22 14:39:08 UTC
Created attachment 348499 [details] [review]
ttmlrender: extend UnifiedBlock type
Comment 7 Chris Bass 2017-03-22 14:39:40 UTC
Created attachment 348500 [details] [review]
ttmlrender: extend UnifiedElement type to include font  metrics
Comment 8 Chris Bass 2017-03-22 14:40:10 UTC
Created attachment 348501 [details] [review]
ttmlrender: add facility to stitch images in both  directions
Comment 9 Chris Bass 2017-03-22 14:40:54 UTC
Created attachment 348502 [details] [review]
ttmlrender: apply correct line height to blocks with multiple text sizes
Comment 10 Chris Bass 2017-03-22 14:41:48 UTC
Created attachment 348503 [details] [review]
ttml: correctly implement lineHeight behaviour
Comment 11 Chris Bass 2017-03-22 14:42:22 UTC
Created attachment 348504 [details] [review]
ttmlrender: relocate type definitions to head of file
Comment 12 Chris Bass 2017-03-22 14:42:52 UTC
Created attachment 348505 [details] [review]
ttmlrender: improve function comments/descriptions
Comment 13 Chris Bass 2017-03-22 14:43:31 UTC
Created attachment 348506 [details] [review]
ttmlparse: don't leak caps
Comment 14 Sebastian Dröge (slomo) 2017-04-09 07:43:11 UTC
Attachment 348496 [details] pushed as ac91886 - ttmlrender: store PangoLayout in object state
Attachment 348498 [details] pushed as 9f0a062 - ttml: add refcounting to GstSubtitleStlyeSet type
Attachment 348499 [details] pushed as aec8406 - ttmlrender: extend UnifiedBlock type
Attachment 348502 [details] pushed as f28df30 - ttmlrender: apply correct line height to blocks with multiple text sizes
Attachment 348503 [details] pushed as 0288ee2 - ttml: correctly implement lineHeight behaviour
Attachment 348504 [details] pushed as ada24bd - ttmlrender: relocate type definitions to head of file
Attachment 348505 [details] pushed as 60bcf63 - ttmlrender: improve function comments/descriptions