After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780381 - Fix a couple of errors and warnings
Fix a couple of errors and warnings
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-22 00:42 UTC by Florian Müllner
Modified: 2017-03-22 17:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
calendar-server: Remove unused variables and function (1.54 KB, patch)
2017-03-22 00:43 UTC, Florian Müllner 		committed Details | Review
st: Add missing %NULL check (1.38 KB, patch)
2017-03-22 00:43 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-03-22 00:42:46 UTC 
See patches.
Comment 1 Florian Müllner 2017-03-22 00:43:10 UTC 
Created attachment 348454 [details] [review]
calendar-server: Remove unused variables and function

The code that used them was removed in commit 7e0e224e0eb8.
Comment 2 Florian Müllner 2017-03-22 00:43:32 UTC 
Created attachment 348455 [details] [review]
st: Add missing %NULL check

st_theme_node_get_border_image() may return %NULL, leading to a
segfault in st_border_image_get_file() when glib is compiled with
G_DISABLE_CHECKS.
Comment 3 Rui Matos 2017-03-22 17:04:09 UTC 
Review of attachment 348454 [details] [review]:

sure
Comment 4 Rui Matos 2017-03-22 17:04:29 UTC 
Review of attachment 348455 [details] [review]:

looks fine
Comment 5 Florian Müllner 2017-03-22 17:53:56 UTC 
Attachment 348454 [details] pushed as 5de85c7 - calendar-server: Remove unused variables and function
Attachment 348455 [details] pushed as b477d21 - st: Add missing %NULL check