After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780380 - Search: Highlight file in folder when activating "Open Item Location"
Search: Highlight file in folder when activating "Open Item Location"
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
3.22.x
Other Linux
: Normal enhancement
: 3.24
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 757852 780379 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-03-22 00:01 UTC by Bastian Ilsø
Modified: 2017-08-23 23:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
files-view: Select file after "Open item location" (2.16 KB, patch)
2017-03-30 15:01 UTC, Carlos Soriano
committed Details | Review
icon-controller: Implement reveal_selection (1.67 KB, patch)
2017-03-30 15:01 UTC, Carlos Soriano
committed Details | Review
files-view: Reveal file in an idle for the flow view (1.11 KB, patch)
2017-03-30 15:01 UTC, Carlos Soriano
committed Details | Review
view-model: Don't remove files when adding items (915 bytes, patch)
2017-03-30 15:06 UTC, Carlos Soriano
committed Details | Review

Description Bastian Ilsø 2017-03-22 00:01:06 UTC
When using Right-click -> Open Item Location, Nautilus currently scroll the window so the file becomes visible inside the location. I think it would be useful if Nautilus aided visual search even further by selecting the file inside the location too.
Comment 1 Carlos Soriano 2017-03-22 09:20:31 UTC
This task is part of gsoc for "Modernize backend and improve developer experience" since one of our core goals for 3.26 (and backport to 3.24) is iron out the search use case of type-ahead.
Comment 2 Carlos Soriano 2017-03-30 15:01:00 UTC
Created attachment 348996 [details] [review]
files-view: Select file after "Open item location"

Until now we weren't selecting the item that was selected.
However it really helps to do that so the user can navigate after
searching. For instance this is pretty good to have for the "type-ahead"
use case.

This commit select the file after the user opens the item location
and reveals the file.
Comment 3 Carlos Soriano 2017-03-30 15:01:05 UTC
Created attachment 348997 [details] [review]
icon-controller: Implement reveal_selection

It was missing in the new GtkFlowBox based view.
Comment 4 Carlos Soriano 2017-03-30 15:01:11 UTC
Created attachment 348998 [details] [review]
files-view: Reveal file in an idle for the flow view

Items are not allocated at that time yet, so it needs some time to be
able to calculate the correct allocation of the item, and therefore the
correct adjustment for the scrolled window.
Comment 5 Carlos Soriano 2017-03-30 15:03:41 UTC
Attachment 348996 [details] pushed as 1b84e20 - files-view: Select file after "Open item location"
Attachment 348997 [details] pushed as 0e6af80 - icon-controller: Implement reveal_selection
Attachment 348998 [details] pushed as 13332ea - files-view: Reveal file in an idle for the flow view
Comment 6 Carlos Soriano 2017-03-30 15:06:52 UTC
Created attachment 348999 [details] [review]
view-model: Don't remove files when adding items

A copy paste error from the set_items function.
Comment 7 Carlos Soriano 2017-03-30 15:11:12 UTC
Comment on attachment 348999 [details] [review]
view-model: Don't remove files when adding items

Attachment 348999 [details] pushed as 634bc0c - view-model: Don't remove files when adding items
Comment 8 Carlos Soriano 2017-04-13 15:09:33 UTC
*** Bug 780379 has been marked as a duplicate of this bug. ***
Comment 9 António Fernandes 2017-08-23 23:15:26 UTC
*** Bug 757852 has been marked as a duplicate of this bug. ***