After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780365 - Cursor in screenshots gets clipped when on desktop edges
Cursor in screenshots gets clipped when on desktop edges
Status: RESOLVED FIXED
Product: gnome-flashback
Classification: Other
Component: screenshot
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Flashback Maintainers
GNOME Flashback Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-21 16:54 UTC by Antonio Ospite
Modified: 2017-03-23 22:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Cursor in screenshots gets clipped when on desktop edges (70.01 KB, image/png)
2017-03-21 16:54 UTC, Antonio Ospite 		  Details
screenshot: fix compositing the cursor when it's on the top or left edge (2.04 KB, patch)
2017-03-22 16:37 UTC, Antonio Ospite 		none Details | Review

Description Antonio Ospite 2017-03-21 16:54:33 UTC 
Created attachment 348429 [details]
Cursor in screenshots gets clipped when on desktop edges

When the cursor is at the edges of the desktop it gets clipped in the final image.

The attached image shows the problem when the cursor is at the bottom edge, it get partially clipped, while I would expect it to be drawn as seen on screen.

Enlarge the image to see the clipping more clearly.

And when the cursor is at the right or left edge it does not get included at all.

Thanks,
   Antonio
Comment 1 Antonio Ospite 2017-03-22 07:54:41 UTC 
The cursor now looks perfect on the bottom and right edges, but it is still not included when it touches the left or the top edge.

Thanks,
   Antonio
Comment 2 Antonio Ospite 2017-03-22 16:37:57 UTC 
Created attachment 348516 [details] [review]
screenshot: fix compositing the cursor when it's on the top or left edge

The attached patch seems to fix the issue.

Alberts could you also double check my reasoning in the commit message? This is the first time I use gdk_pixbuf_composite() and the offsets arguments are not exactly straightforward.

Thanks,
   Antonio
Comment 3 Alberts Muktupāvels 2017-03-23 22:56:01 UTC 
I hope that this is now really fixed...

I don't understand offset arguments too, but now it seems to work as intended. Please reopen if you still find cases when cursor is included incorrectly.