After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780360 - Handle devices without precise capacity
Handle devices without precise capacity
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Power
git master
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
triaged
Depends on:
Blocks:
 
 
Reported: 2017-03-21 16:32 UTC by Bastien Nocera
Modified: 2020-06-16 11:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
power: Don't show approximate percentages (2.45 KB, patch)
2018-04-19 02:16 UTC, Bastien Nocera
committed Details | Review
touchpad.png (67.54 KB, image/png)
2020-06-16 11:43 UTC, Bastien Nocera
  Details

Description Bastien Nocera 2017-03-21 16:32:31 UTC
The Logitech T650 has 5 levels of battery, which can roughly correspond to percentages:
https://cgit.freedesktop.org/upower/tree/src/linux/hidpp-device.c#n878

But the M325 mouse only has 2 levels of battery, "OK" or "critical".

So a level bar isn't exactly great...
Comment 1 Peter Hutterer 2017-03-27 01:25:35 UTC
Mostly just thinking aloud here, but what about changing from an objective state to something a user must do (or not do) - "fine", "needs recharging soon", "needs recharge". That's easier to map into a non-continuous state.
Comment 2 Bastien Nocera 2017-05-31 15:25:30 UTC
(In reply to Peter Hutterer from comment #1)
> Mostly just thinking aloud here, but what about changing from an objective
> state to something a user must do (or not do) - "fine", "needs recharging
> soon", "needs recharge". That's easier to map into a non-continuous state.

That sounds good. But we'd still need to know how to show that graphically, hence the ui-review tag.
Comment 3 Bastien Nocera 2018-04-19 02:16:15 UTC
Created attachment 371121 [details] [review]
power: Don't show approximate percentages

When there's a battery-level property (new in UPower 0.99.5), don't show
the percentage, as it's a rough approximation of the truth.
Comment 4 Bastien Nocera 2018-04-19 02:19:46 UTC
(In reply to Bastien Nocera from comment #0)
> The Logitech T650 has 5 levels of battery, which can roughly correspond to
> percentages:
> https://cgit.freedesktop.org/upower/tree/src/linux/hidpp-device.c#n878
> 
> But the M325 mouse only has 2 levels of battery, "OK" or "critical".
> 
> So a level bar isn't exactly great...

And the T650, and the Logitech Performance MX mouse both have no idea what the battery level is when charging. They know it's charging, and they'll know the battery isn't full. Maybe an animation of some sort?

Peter, do you know how those battery states are shown on Windows for example? I expect those are shown in Logitech's own software rather than integrated in the OS.
Comment 5 Bastien Nocera 2018-04-19 12:41:00 UTC
Attachment 371121 [details] pushed as 6c447dc - power: Don't show approximate percentages
Comment 6 Bastien Nocera 2018-04-19 12:59:08 UTC
Pushed the wrong patch :/

Let's say it was a good way to get the ball rolling and not revert it.
Comment 8 Allan Day 2018-04-26 09:21:31 UTC
(In reply to Bastien Nocera from comment #7)
> Mockups from Allan:
> https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/
> system-settings/power/power-wires.png

These are just a quick attempt - I'm happy to elaborate as necessary.
Comment 9 Peter Hutterer 2018-04-27 07:02:17 UTC
> Peter, do you know how those battery states are shown on Windows for example?

no idea, sorry, but the mockups look good
Comment 10 Bastien Nocera 2018-07-17 11:17:48 UTC
(In reply to Peter Hutterer from comment #9)
> > Peter, do you know how those battery states are shown on Windows for example?
> 
> no idea, sorry, but the mockups look good

The mockups look good, but we don't actually know whether the device has 5 (or 4, or 3) or 2 states. I guess that would mean going for the label option every time.
Comment 11 Bastien Nocera 2020-06-16 11:43:20 UTC
Created attachment 374265 [details]
touchpad.png

We've already removed the percentage label. And the bar looks fine for approximate values (other than the colour, see https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/725).

Let's call it good enough, and we can always revisit in another bug on GitLab if we want to change that.