After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780358 - Screenshot of a selection draws also the selection overlay
Screenshot of a selection draws also the selection overlay
Status: RESOLVED FIXED
Product: gnome-flashback
Classification: Other
Component: screenshot
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Flashback Maintainers
GNOME Flashback Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-21 16:19 UTC by Antonio Ospite
Modified: 2017-05-10 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of a selection draws also the selection overlay (9.67 KB, image/png)
2017-03-21 16:19 UTC, Antonio Ospite
  Details
media-keys: don't include selection overlay in screenshot (1.39 KB, patch)
2017-05-03 10:57 UTC, Alberts Muktupāvels
rejected Details | Review

Description Antonio Ospite 2017-03-21 16:19:06 UTC
Created attachment 348421 [details]
Screenshot of a selection draws also the selection overlay

Sometimes when capturing the screenshot of a manual selection (e.g. Shift+PrintScreen) the selection overlay gets drawn into the final screenshot.

See the attached image, the original background is white, but it becomes blue-ish because the selection overlay gets drawn on top of it.

It does not always happen, tho, not sure if it's some race condition or if there is some specific condition that triggers the bug.

Thanks,
   Antonio
Comment 1 Thierry C. 2017-05-03 07:26:41 UTC
I have exactly the same issue with gnome 3.22.3 under fedora 25 except i've never seen it work as expected (without the blue selection overlay).

Sometimes the overlay is not covering the whole selection area, like it was lagging behind the mouse cursor.

I have only 2 gnome-shell extensions active : 'Topicons plus', and 'Window list'.

My workaround is to take a full-screen screenshot , and then do the area selection under a image editing software, which is time consuming. (Other area screenshot applications like shutter are not working under wayland).
Comment 2 Antonio Ospite 2017-05-03 08:34:40 UTC
I think this bugs should be reassigned to gnome-settings-daemon as GSD is the piece of software which handles the PrintScreen capturing modes.

Same for https://bugzilla.gnome.org/show_bug.cgi?id=780357

Any comment?
Comment 3 Alberts Muktupāvels 2017-05-03 10:57:53 UTC
Created attachment 350962 [details] [review]
media-keys: don't include selection overlay in screenshot

Use timeout to give compositor some time to finish redrawing
selected area without selection overlay.
Comment 4 Antonio Ospite 2017-05-03 11:08:37 UTC
gnome-screenshot also seems to be doing something similar at the end of screenshot_select_area_x11_async() https://git.gnome.org/browse/gnome-screenshot/tree/src/screenshot-area-selection.c#n226

Thanks Alberts.
Comment 5 Bastien Nocera 2017-05-03 11:22:10 UTC
(In reply to Antonio Ospite from comment #2)
> I think this bugs should be reassigned to gnome-settings-daemon as GSD is
> the piece of software which handles the PrintScreen capturing modes.

Which just calls out to gnome-shell.
Comment 6 Florian Müllner 2017-05-03 13:07:52 UTC
Mmh, this is odd - the code is certainly meant to only emit the 'finished' signal after the fade out is complete (that is, the selection rectangle has an opacity of 0):

https://git.gnome.org//browse/gnome-shell/tree/js/ui/screenshot.js#n314

It's not immediately obvious why this would fail. Do people see this on both X11 and wayland?
Comment 7 Alberts Muktupāvels 2017-05-10 18:12:15 UTC
Thierry C., please open new bug for gnome-shell.

This bug was about gnome-flashback and I can not reproduce this in gnome-shell, tested with 3.24.