After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780353 - Import bookmarks from Firefox should ignore mobile bookmarks
Import bookmarks from Firefox should ignore mobile bookmarks
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Bookmarks
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-21 13:41 UTC by Gabriel Ivașcu
Modified: 2017-08-16 09:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
When importing bookmarks from Firefox set mobile bookmarks under Mobile tag (4.91 KB, patch)
2017-08-15 21:18 UTC, Gabriel Ivașcu 		committed Details | Review

Description Gabriel Ivașcu 2017-03-21 13:41:35 UTC 
I have recently imported my bookmarks from Firefox and noticed that a bunch of mobile websites were added to my bookmarks (e.g. http://m.imdb.com/).

I think that it would make sense to import only desktop bookmarks and ignore mobile bookmarks (i.e. bookmarks with parentid set to "mobile" and parentName set to "Mobile Bookmarks").
Comment 1 Daniel Aleksandersen 2017-04-21 12:17:29 UTC 
No. This only makes sense if you only use the desktop browsers. For users who use Firefox Sync and Firefox for Android or iOS, they’d expect their bookmarks to be imported as well. Epiphany can’t [yet] read minds and it’s better to actually import all bookmarks than to make arbitrary decisions that potentially loose some bookmarks. You did have those bookmarks in your Firefox profile, and Epiphany imported all bookmarks from your Firefox instance.
Comment 2 Gabriel Ivașcu 2017-08-15 21:18:14 UTC 
(In reply to Daniel Aleksandersen from comment #1)
> No. This only makes sense if you only use the desktop browsers. For users
> who use Firefox Sync and Firefox for Android or iOS, they’d expect their
> bookmarks to be imported as well. Epiphany can’t [yet] read minds and it’s
> better to actually import all bookmarks than to make arbitrary decisions
> that potentially loose some bookmarks. You did have those bookmarks in your
> Firefox profile, and Epiphany imported all bookmarks from your Firefox
> instance.

OK. Since mobile bookmarks are synced with Firefox Sync under a Mobile tag, I guess it makes sense that imported mobile bookmarks should also be under the same Mobile tag.
Comment 3 Gabriel Ivașcu 2017-08-15 21:18:44 UTC 
Created attachment 357675 [details] [review]
When importing bookmarks from Firefox set mobile bookmarks under Mobile tag