After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780340 - configure check for id3mux is broken
configure check for id3mux is broken
Status: RESOLVED OBSOLETE
Product: gnome-sound-recorder
Classification: Other
Component: General
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-sound-recorder maintainer(s)
gnome-sound-recorder maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-21 07:14 UTC by David King
Modified: 2018-05-22 12:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
drop the check failure to a warning (813 bytes, patch)
2017-03-21 07:17 UTC, David King 		none Details | Review

Description David King 2017-03-21 07:14:55 UTC 
The configure check for the id3mux element claims:

# Check for elements from gst-plugins-bad
# but don't exit if they aren't installed. Just print error.

However, AC_MSG_ERROR is used to print the error, which causes the configure script to abort if id3mux is not found. AC_MSG_WARN would be appropriate instead.
Comment 1 David King 2017-03-21 07:17:46 UTC 
Created attachment 348377 [details] [review]
drop the check failure to a warning
Comment 2 Meg Ford 2017-03-21 18:00:19 UTC 
Ugh I missed that one, thanks! Will apply this tonight. Do you need me to make a new release?
Comment 3 David King 2017-03-21 18:48:00 UTC 
(In reply to Meg Ford from comment #2)
> Ugh I missed that one, thanks! Will apply this tonight. Do you need me to
> make a new release?

I already worked around it in the Fedora packaging (and it is problematic for Fedora because the main repositories do not have any support for MP3 encoding due to patent restrictions in the US), so it depends on whether it will be a problem for other packagers. I guess that it would be a problem, so another release would be a good idea.
Comment 4 Meg Ford 2017-03-21 20:20:54 UTC 
yeah, that's why I was just doing a warning not an error. I copied back the changes from testing on Debian and missed that line. Sorry about that! Will do a new release tonight.
Comment 5 GNOME Infrastructure Team 2018-05-22 12:59:45 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-sound-recorder/issues/28.