After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780318 - gnome-games 3.24.0.1 tarball missing files
gnome-games 3.24.0.1 tarball missing files
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-20 16:56 UTC by Jeremy Bicha
Modified: 2017-03-21 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
data: Distribute more files (2.50 KB, patch)
2017-03-20 16:56 UTC, Jeremy Bicha
none Details | Review

Description Jeremy Bicha 2017-03-20 16:56:01 UTC
make[2]: *** No rule to make target 'gamepads/gamecontrollerdb.txt', needed by 'resources.c'.  Stop.

Here's an untested patch to dist some more files.

Other files that appear to be missing are:
autogen.sh
plugins/desktop/data/blacklists/*
plugins/mame/data/supported-games
plugins/mame/tools/extract-suported-games.sh (typo, should be supported)
plugins/playstation/data/playstation.gameinfo.xml.in
src/gamepad/linux/libevdep.vapi
tools/*

Also this commit looks missing from your 3.24.0.1 tarball:
https://git.gnome.org/browse/gnome-games/commit/?id=431a74ef5
Comment 1 Jeremy Bicha 2017-03-20 16:56:05 UTC
Created attachment 348335 [details] [review]
data: Distribute more files
Comment 2 Adrien Plazas 2017-03-21 08:25:55 UTC
Review of attachment 348335 [details] [review]:

::: data/icons/Makefile.am
@@ +39,3 @@
 hicontrast_icon256_DATA = HighContrast/256x256/apps/org.gnome.Games.png
+hicontrast_icon256dir = $(datadir)/icons/HighContrast/512x512/apps
+hicontrast_icon256_DATA = HighContrast/512x512/apps/org.gnome.Games.png

I suppose it's not 256 but 512 here?
Comment 3 Jeremy Bicha 2017-03-21 12:29:13 UTC
(In reply to Adrien Plazas from comment #2)
> I suppose it's not 256 but 512 here?

Yes
Comment 4 Jeremy Bicha 2017-03-21 15:25:21 UTC
Thanks. I can successfully build 3.24.0.2 now.