After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780317 - avvidenc: Classify image encoders with "Image" instead of "Video"
avvidenc: Classify image encoders with "Image" instead of "Video"
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
unspecified
Other All
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-20 16:51 UTC by Arun Raghavan
Modified: 2017-03-22 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
avvidenc: Classify image encoders with "Image" instead of "Video" (3.22 KB, patch)
2017-03-20 16:51 UTC, Arun Raghavan 		none Details | Review
avvidenc: Classify image encoders with "Image" instead of "Video" (3.19 KB, patch)
2017-03-21 04:20 UTC, Arun Raghavan 		committed Details | Review
avvidenc: Classify image encoders with "Image" instead of "Video" (3.19 KB, patch)
2017-03-22 07:04 UTC, Arun Raghavan 		committed Details | Review

Description Arun Raghavan 2017-03-20 16:51:00 UTC 
This allows gst_video_convert_sample*() to work with codecs for which we
have libav encoders (such as BMP).
Comment 1 Arun Raghavan 2017-03-20 16:51:06 UTC 
Created attachment 348334 [details] [review]
avvidenc: Classify image encoders with "Image" instead of "Video"
Comment 2 Sebastian Dröge (slomo) 2017-03-20 16:56:22 UTC 
Review of attachment 348334 [details] [review]:

::: ext/libav/gstavcodecmap.c
@@ +730,3 @@
+    case AV_CODEC_ID_MJPEG:
+    case AV_CODEC_ID_LJPEG:
+    case AV_CODEC_ID_JPEG2000:

JPEG2000 is video most of the time, and openjpegenc is Codec/Encoder/Video
Comment 3 Arun Raghavan 2017-03-21 04:19:26 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 348334 [details] [review] [review]:
> 
> ::: ext/libav/gstavcodecmap.c
> @@ +730,3 @@
> +    case AV_CODEC_ID_MJPEG:
> +    case AV_CODEC_ID_LJPEG:
> +    case AV_CODEC_ID_JPEG2000:
> 
> JPEG2000 is video most of the time, and openjpegenc is Codec/Encoder/Video

Fair enough, will drop it. I wonder if we should add 'Image' (while keeping 'Video') to it.
Comment 4 Arun Raghavan 2017-03-21 04:20:16 UTC 
Created attachment 348373 [details] [review]
avvidenc: Classify image encoders with "Image" instead of "Video"

This allows gst_video_convert_sample*() to work with codecs for which we
have libav encoders (such as BMP).
Comment 5 Arun Raghavan 2017-03-22 07:04:03 UTC 
The following fix has been pushed:
2e25f16 avvidenc: Classify image encoders with "Image" instead of "Video"
Comment 6 Arun Raghavan 2017-03-22 07:04:20 UTC 
Created attachment 348461 [details] [review]
avvidenc: Classify image encoders with "Image" instead of "Video"

This allows gst_video_convert_sample*() to work with codecs for which we
have libav encoders (such as BMP).