After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780314 - commit: Fix invalid assignment from owned expression to unowned variable
commit: Fix invalid assignment from owned expression to unowned variable
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-20 15:49 UTC by Rico Tzschichholz
Modified: 2017-06-22 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
commit: Fix invalid assignment from owned expression to unowned variable (1.24 KB, patch)
2017-03-20 15:50 UTC, Rico Tzschichholz 		committed Details | Review

Description Rico Tzschichholz 2017-03-20 15:49:57 UTC 
commit is an unowned parameter of stage_submodule() and be used to keep an owned reference returned by repo.lookup().


gitg/commit/gitg-commit.vala:258.7-258.71: error: Invalid assignment from owned expression to unowned variable
						commit = repo.lookup<Gitg.Commit>(sub.submodule.get_workdir_id());
						^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Comment 1 Rico Tzschichholz 2017-03-20 15:50:18 UTC 
Created attachment 348328 [details] [review]
commit: Fix invalid assignment from owned expression to unowned variable

commit is an unowned parameter of stage_submodule() and be used to keep
an owned reference returned by repo.lookup().
Comment 2 Rico Tzschichholz 2017-06-22 14:53:49 UTC 
Ping
Comment 3 Ignacio Casal Quinteiro (nacho) 2017-06-22 15:00:06 UTC 
Review of attachment 348328 [details] [review]:

Thanks
Comment 4 Rico Tzschichholz 2017-06-22 15:48:51 UTC 
Attachment 348328 [details] pushed as 5b195d6 - commit: Fix invalid assignment from owned expression to unowned variable