After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780312 - keyboard: Fix check for existing shortcut settings
keyboard: Fix check for existing shortcut settings
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-20 15:29 UTC by Rui Matos
Modified: 2017-03-23 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Fix check for existing shortcut settings (1.12 KB, patch)
2017-03-20 15:29 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2017-03-20 15:29:21 UTC 
Minor issue uncovered by coverity
Comment 1 Rui Matos 2017-03-20 15:29:25 UTC 
Created attachment 348325 [details] [review]
keyboard: Fix check for existing shortcut settings

From a Coverity scan:

panels/keyboard/cc-keyboard-manager.c:208: unreachable: Since the loop
increment "i++;" is unreachable, the loop body will never execute more
than once.

This seems like a logic thinko introduced in commit
3207fe97ec516c11f2f781269f9342f36fa8161b . In practice it was unlikely
to be a problem since we don't have repeated shortcut gsettings key
names in all our KeyListEntries files.
Comment 2 Bastien Nocera 2017-03-21 10:56:45 UTC 
Review of attachment 348325 [details] [review]:

Sure.
Comment 3 Rui Matos 2017-03-23 16:17:10 UTC 
Attachment 348325 [details] pushed as 034181d - keyboard: Fix check for existing shortcut settings