After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780306 - Unused function in gunicollate.c for CARBON
Unused function in gunicollate.c for CARBON
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.52.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-03-20 14:21 UTC by Daniel Macks
Modified: 2017-03-22 03:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix #if controls to sync with those of g_utf8_collate_key (1.07 KB, patch)
2017-03-20 14:25 UTC, Daniel Macks 		committed Details | Review

Description Daniel Macks 2017-03-20 14:21:42 UTC 
Building glib-2.52.0 on OS X 10.11:

gunicollate.c:174:1: warning: unused function 'utf8_encode' [-Wunused-function]
utf8_encode (char *buf, wchar_t val)
^
1 warning generated.


That function is used by some implementations of g_utf8_collate_key, but not for the carbon (OS X) implementation. There is already platform-specific #ifdef control for utf8_encode, just need to update it to omit carbon.
Comment 1 Daniel Macks 2017-03-20 14:25:25 UTC 
Created attachment 348320 [details] [review]
Fix #if controls to sync with those of g_utf8_collate_key
Comment 2 Philip Withnall 2017-03-21 08:51:19 UTC 
My review didn’t get published for some reason, but the patch was a-c-n. Thanks.