After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780302 - Build failures when Gstreamer is built with --disable-gst-debug
Build failures when Gstreamer is built with --disable-gst-debug
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
1.10.3
Other Linux
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-20 14:07 UTC by Rahul Bedarkar
Modified: 2017-04-07 11:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: when debug disabled, default category is NULL (2.79 KB, patch)
2017-03-20 15:53 UTC, Víctor Manuel Jáquez Leal 		committed Details | Review

Description Rahul Bedarkar 2017-03-20 14:07:06 UTC 
When Gstreamer is built with --disable-gst-debug, gstreamer-vaapi fails with following errors.

gstvaapidecode.c: In function 'gst_vaapidecode_init':
gstvaapidecode.c:52:25: error: 'gst_debug_vaapidecode' undeclared (first use in this function)
 #define GST_CAT_DEFAULT gst_debug_vaapidecode
                         ^
gstvaapidecode.c:1365:63: note: in expansion of macro 'GST_CAT_DEFAULT'
   gst_vaapi_plugin_base_init (GST_VAAPI_PLUGIN_BASE (decode), GST_CAT_DEFAULT);
                                                               ^
gstvaapidecode.c:52:25: note: each undeclared identifier is reported only once for each function it appears in
 #define GST_CAT_DEFAULT gst_debug_vaapidecode
                         ^
gstvaapidecode.c:1365:63: note: in expansion of macro 'GST_CAT_DEFAULT'
   gst_vaapi_plugin_base_init (GST_VAAPI_PLUGIN_BASE (decode), GST_CAT_DEFAULT);
                                                               ^
gstvaapipostproc.c: In function 'gst_vaapipostproc_init':
gstvaapipostproc.c:52:25: error: 'gst_debug_vaapipostproc' undeclared (first use in this function)
 #define GST_CAT_DEFAULT gst_debug_vaapipostproc
                         ^
gstvaapipostproc.c:1811:7: note: in expansion of macro 'GST_CAT_DEFAULT'
       GST_CAT_DEFAULT);
       ^
gstvaapipostproc.c:52:25: note: each undeclared identifier is reported only once for each function it appears in
 #define GST_CAT_DEFAULT gst_debug_vaapipostproc
                         ^
gstvaapipostproc.c:1811:7: note: in expansion of macro 'GST_CAT_DEFAULT'
       GST_CAT_DEFAULT);
       ^
make[4]: *** [libgstvaapi_la-gstvaapidecode.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [libgstvaapi_la-gstvaapipostproc.lo] Error 1

This build issue is detected by Buildroot autobuilders:

http://autobuild.buildroot.net/?reason=gst1-vaapi-1.10.3
Comment 1 Víctor Manuel Jáquez Leal 2017-03-20 15:53:28 UTC 
Created attachment 348330 [details] [review]
plugins: when debug disabled, default category is NULL

As in gstreamer-vaapi a common base class is used, the specific
default category is passed to the base-plugin initializator, thus
the log messages are categorized with the used plugin.

Nonetheless, when the gst-debug is disabled in compilation time,
it is needed to pass NULL to the base-plugin initializator. This
patch does that.
Comment 2 Víctor Manuel Jáquez Leal 2017-03-20 15:57:04 UTC 
Rahul, does this patch works for you?
Comment 3 Rahul Bedarkar 2017-03-20 18:07:27 UTC 
It works for me.

Thanks,
Rahul
Comment 4 Víctor Manuel Jáquez Leal 2017-03-20 18:18:34 UTC 
Attachment 348330 [details] pushed as 1522170 - plugins: when debug disabled, default category is NULL