After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780273 - cleanup: Use arrow notation for anonymous functions
cleanup: Use arrow notation for anonymous functions
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-19 18:15 UTC by Florian Müllner
Modified: 2017-04-11 00:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cleanup: Use arrow notation for anonymous functions (80.89 KB, patch)
2017-03-19 18:15 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-03-19 18:15:47 UTC
See patch.

(It looks somewhat less scary when viewed with -w, i.e. `git log -p -w`)
Comment 1 Florian Müllner 2017-03-19 18:15:53 UTC
Created attachment 348269 [details] [review]
cleanup: Use arrow notation for anonymous functions

Arrow notation is great, but as we only started using it recently,
we currently have a wild mix of Lang.bind(this, function() {}),
function() {} and () => {}. To make the style consistent again,
go through the entire codebase and change all anonymous functions
to arrow notation (using /[^:].function/ for identifying them).
Comment 2 Florian Müllner 2017-04-11 00:50:23 UTC
Attachment 348269 [details] pushed as 2f3d808 - cleanup: Use arrow notation for anonymous functions