After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780132 - h264parse: update src caps with sps in case of byte-stream/nal earlier
h264parse: update src caps with sps in case of byte-stream/nal earlier
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-16 09:54 UTC by Hyunjun Ko
Modified: 2018-11-03 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
h264parse: update src caps with sps in case of byte-stream/nal (2.16 KB, patch)
2017-03-16 09:56 UTC, Hyunjun Ko 		none Details | Review

Description Hyunjun Ko 2017-03-16 09:54:53 UTC 
Since it starts a bit of buffering in byte-stream/nal, we can parse sps at preroll time. So I propose this patch.

This makes decodebin to be able to judge if a decoder is available or not at preroll time.

But I'm not sure this makes sense.
Need for review.
Comment 1 Hyunjun Ko 2017-03-16 09:56:12 UTC 
Created attachment 348068 [details] [review]
h264parse: update src caps with sps in case of  byte-stream/nal
Comment 2 Tim-Philipp Müller 2018-01-24 13:09:32 UTC 
Sorry, I am not sure if I understand the scenario entirely. Does

commit 5ac886d85aab4b919f84fb80e2d1ef36dc8e647d
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed Nov 22 14:35:31 2017 +0100

    h264parse: early set src caps when input is avc
    
    When input is in AVC format there is no need to wait for the first buffer
    before setting src caps. We already have all the information from the
    input codec_data.
    
    This allow us to already configure downstream elements allowing them,
    for example, to already allocate their internal buffers as they know
    the format of the input they are about to receive.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=790709


cover this as well or is your patch for a different scenario?
Comment 3 GStreamer system administrator 2018-11-03 14:06:00 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/535.