After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780051 - week-view: every full-day event is off by 2 days.
week-view: every full-day event is off by 2 days.
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: Views
unspecified
Other Linux
: Normal major
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-14 19:02 UTC by Mohammed Sadiq
Modified: 2017-03-15 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
week-header: don't account first weekday twice (1.82 KB, patch)
2017-03-14 23:34 UTC, Georges Basile Stavracas Neto 		committed Details | Review
week-header: fix calc of events' start and end positions (1.18 KB, patch)
2017-03-15 12:19 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Mohammed Sadiq 2017-03-14 19:02:31 UTC 
Every full day event in week-view is off by two days. For example, an event on March 23rd is shown in March 25th.
Comment 1 Georges Basile Stavracas Neto 2017-03-14 23:34:02 UTC 
Created attachment 347966 [details] [review]
week-header: don't account first weekday twice

The auxiliary functions to calculate the week start
already takes the first weekday into account. We,
however, were considering it again when calculating
the event position.

Fix that by only considering it once, through the
get_start_of_week() function.
Comment 2 Georges Basile Stavracas Neto 2017-03-14 23:34:28 UTC 
Thanks for the report.

Attachment 347966 [details] pushed as f608f8f - week-header: don't account first weekday twice
Comment 3 Mohammed Sadiq 2017-03-15 01:40:18 UTC 
Full day events are still off my one column.

Eg: In a week 13-19, Event on 15th is shown in 16th, and event on 19th is shown in 13th.
Comment 4 Georges Basile Stavracas Neto 2017-03-15 12:19:35 UTC 
Created attachment 348002 [details] [review]
week-header: fix calc of events' start and end positions

Another shot in this issue. Again.
Comment 5 Georges Basile Stavracas Neto 2017-03-15 12:20:16 UTC 
Thanks for reopening this bug. I think now it's fixed.

Attachment 348002 [details] pushed as 669869c - week-header: fix calc of events' start and end positions