After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780024 - qtmux: add support for CineForm
qtmux: add support for CineForm
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.11.x
Other All
: Normal enhancement
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-14 09:43 UTC by emeric.grange
Modified: 2017-03-14 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
support for CineForm codec in qtdemux and qtmux (3.21 KB, patch)
2017-03-14 09:43 UTC, emeric.grange 		committed Details | Review
avcodecmap: Add mapping for CineForm HD / CFHD codec (1.25 KB, patch)
2017-03-14 13:02 UTC, Sebastian Dröge (slomo) 		committed Details | Review
map (1.42 KB, application/mbox)
2017-03-14 13:59 UTC, emeric.grange 		  Details

Description emeric.grange 2017-03-14 09:43:11 UTC 
Created attachment 347903 [details] [review]
support for CineForm codec in qtdemux and qtmux

The attached patch is adding support for the CineForm video codec in qtdemux and qtmux.
Comment 1 Sebastian Dröge (slomo) 2017-03-14 13:00:09 UTC 
Comment on attachment 347903 [details] [review]
support for CineForm codec in qtdemux and qtmux

The patch looks good, but having a sample file for future reference would be useful. Also we should add support for this via ffmpeg, currently the caps mapping is missing.

Is video/x-cineform also the mimetype that you're using for this codec? ffmpeg calls it cfhd (AV_CODEC_ID_CFHD), so video/x-cfhd would be another option.
Comment 2 Sebastian Dröge (slomo) 2017-03-14 13:02:00 UTC 
Created attachment 347919 [details] [review]
avcodecmap: Add mapping for CineForm HD / CFHD codec
Comment 3 emeric.grange 2017-03-14 13:57:23 UTC 
I can upload you a short CineForm sample but is a wetransfer link or something similar acceptable, because CineForm videos are always pretty heavy...

I have a patch for mapping the CineForm decoder from ffpmeg but some requierd pixel formats are missing from GStreamer I believe (see WIP patch attached).

CFHD is the "usual" fourcc associated with this codec (short for "CineForm HD") but now we mostly use the name "GoPro CineForm". I think x-cineform would be more descriptive but I don't really mind.
Comment 4 emeric.grange 2017-03-14 13:59:20 UTC 
Created attachment 347922 [details]
map

map CineForm cap
Comment 5 Sebastian Dröge (slomo) 2017-03-14 14:02:37 UTC 
wetransfer or similar would be fine, thanks :)
Comment 6 emeric.grange 2017-03-14 15:17:10 UTC 
Ok I uploaded three videos using three different pixel formats on dropbox: https://www.dropbox.com/sh/x6f0pm7ifaxgq47/AAB9tahh8PHHxBx27Ln-ywQ6a?dl=0
Comment 7 Sebastian Dröge (slomo) 2017-03-14 16:04:46 UTC 
commit 534be3313c87e56887650ae8a1dd8c5b8863949e
Author: Emeric Grange <egrange@gopro.com>
Date:   Tue Mar 14 10:10:19 2017 +0100

    qtmux: add CineForm support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=780024
Comment 8 Sebastian Dröge (slomo) 2017-03-14 16:05:03 UTC 
Attachment 347919 [details] pushed as 887e45e - avcodecmap: Add mapping for CineForm HD / CFHD codec