After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779987 - release tarballs don't have generated files
release tarballs don't have generated files
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-13 15:37 UTC by Jeremy Bicha
Modified: 2017-03-20 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Make .xz tarballs by default (671 bytes, patch)
2017-03-13 15:39 UTC, Jeremy Bicha
committed Details | Review
build: Make .xz tarballs by default (657 bytes, patch)
2017-03-19 02:17 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2017-03-13 15:37:49 UTC
The retro-gtk release tarballs aren't generated like the other GNOME tarballs. I have to manually run ./autogen.sh as part of my build.

This is an excerpt from the retro-gtk build but I think gnome-games has the same issue:

checking for RETRO_GTK... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating retro-gtk/retro-gtk-0.10.pc
config.status: creating retro-gtk/Makefile
config.status: error: cannot find input file: `po/Makefile.in.in'

I believe all you need to do to create the tarball is
./autogen.sh
make
make dist

(There might be a way to do that through jhbuild but you'll have to ask someone else about that.)

Also, you didn't bump the configure.ac for the new retro-gtk release (which you'll need to do for 'make dist' to produce the right filename).
Comment 1 Jeremy Bicha 2017-03-13 15:39:15 UTC
Created attachment 347849 [details] [review]
build: Make .xz tarballs by default

Here's some extra options that will help make dist.

I believe 'foreign' is if you don't want to have all the stuff GNU projects require.
Comment 2 Adrien Plazas 2017-03-14 08:39:59 UTC
Review of attachment 347849 [details] [review]:

LGTM.
Comment 3 Adrien Plazas 2017-03-14 08:40:37 UTC
Attachment 347849 [details] pushed as 7cfaee4 - build: Make .xz tarballs by default
Comment 4 Jeremy Bicha 2017-03-19 02:17:35 UTC
Created attachment 348244 [details] [review]
build: Make .xz tarballs by default
Comment 5 Jeremy Bicha 2017-03-19 02:17:59 UTC
This patch is for gnome-games ^
Comment 6 Adrien Plazas 2017-03-20 09:52:33 UTC
Attachment 348244 [details] pushed as b6fe8cc - build: Make .xz tarballs by default