After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779976 - Patches from Endless
Patches from Endless
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-13 12:01 UTC by Krzesimir Nowak
Modified: 2017-03-13 21:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ide: don't try to steal stream data if it failed to close (1.34 KB, patch)
2017-03-13 12:01 UTC, Krzesimir Nowak
committed Details | Review
gca: don't return an error when not available (1.23 KB, patch)
2017-03-13 12:02 UTC, Krzesimir Nowak
committed Details | Review
flatpak: don't call json_node_* methods on NULL nodes (1.97 KB, patch)
2017-03-13 12:02 UTC, Krzesimir Nowak
committed Details | Review
ide-subprocess: instrument another function (959 bytes, patch)
2017-03-13 12:03 UTC, Krzesimir Nowak
committed Details | Review
ide-subprocess: count outstanding operations beforehand (2.68 KB, patch)
2017-03-13 12:03 UTC, Krzesimir Nowak
committed Details | Review

Description Krzesimir Nowak 2017-03-13 12:01:13 UTC
Created attachment 347824 [details] [review]
ide: don't try to steal stream data if it failed to close

We have some patches at the Endless for of the GNOME Builder, so we would like to upstream them, instead of maintaining them ourselves.

All of them actually seem to be written by Cosimo, so I'm CCing him here.
Comment 1 Krzesimir Nowak 2017-03-13 12:02:08 UTC
Created attachment 347825 [details] [review]
gca: don't return an error when not available
Comment 2 Krzesimir Nowak 2017-03-13 12:02:43 UTC
Created attachment 347827 [details] [review]
flatpak: don't call json_node_* methods on NULL nodes
Comment 3 Krzesimir Nowak 2017-03-13 12:03:23 UTC
Created attachment 347828 [details] [review]
ide-subprocess: instrument another function
Comment 4 Krzesimir Nowak 2017-03-13 12:03:50 UTC
Created attachment 347829 [details] [review]
ide-subprocess: count outstanding operations beforehand
Comment 5 Alexandre Franke 2017-03-13 15:45:09 UTC
Thanks a lot for submitting those and for trying to keep things upstream, we appreciate it!

What were those patches generated with? Are they kept in git at Endless? “seem to be written by Cosimo” is not really reassuring, you should have a way to track precisely that sort of things.
Comment 6 Krzesimir Nowak 2017-03-13 16:17:35 UTC
In general, Endless has the gnome-builder fork here - https://github.com/endlessm/gnome-builder, the PR with these patches is here - https://github.com/endlessm/gnome-builder/pull/6, you should find those patches in the very recent history, on a first page even - https://github.com/endlessm/gnome-builder/commits/master 

I recently did a rebase of the fork on the current master upstream branch, so all the not-yet-upstreamed patched surfaced. The result is here - https://github.com/kinvolk/gnome-builder/commits/krnowak/endless-master-rebase, it's not yet pushed to the fork, but I was asked to upstream some of them. I didn't upstream the first one as it certainly wouldn't be accepted and the last one which is IMO wrong.
Comment 7 Alexandre Franke 2017-03-13 16:21:54 UTC
Given your patches come from git, you should use `git format-patch` to generate them. That will ensure they contain the necessary metadata (author, commit they apply on).
Comment 8 Krzesimir Nowak 2017-03-13 16:25:18 UTC
But I did generate them with git format-patch…
Comment 9 Alexandre Franke 2017-03-13 16:26:51 UTC
Nevermind, I followed the wrong link and got the diff without the header. Thanks again for your submission!
Comment 10 Krzesimir Nowak 2017-03-13 16:29:40 UTC
BTW. The patches were generated from this branch, which is recent upstream master + those 5 patches:

https://github.com/kinvolk/gnome-builder/commits/krnowak/endless-patches-on-upstream
Comment 11 Cosimo Cecchi 2017-03-13 18:17:37 UTC
Thanks, Krzesimir! I also confirm that I'm the original author of these patches :-)
Comment 12 Christian Hergert 2017-03-13 21:01:36 UTC
Excellent, everything looks great!

Attachment 347824 [details] pushed as 0a9fb79 - ide: don't try to steal stream data if it failed to close
Attachment 347825 [details] pushed as fd96d48 - gca: don't return an error when not available
Attachment 347827 [details] pushed as f0c4ba7 - flatpak: don't call json_node_* methods on NULL nodes
Attachment 347828 [details] pushed as 6d5d991 - ide-subprocess: instrument another function
Attachment 347829 [details] pushed as 5e25df7 - ide-subprocess: count outstanding operations beforehand