After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779968 - Manual fails to build with xsltproc < 1.1.27
Manual fails to build with xsltproc < 1.1.27
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Documentation
0.35.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-13 07:52 UTC by Rico Tzschichholz
Modified: 2017-03-13 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Rico Tzschichholz 2017-03-13 07:52:51 UTC 
Looks like xsltproc 1.1.26 is not happy with common.xsl

/usr/bin/xsltproc \
		--xinclude \
		--path . \
		--output devhelp/vala-0.36.devhelp2 \
		./devhelp.xsl \
		./manual.xml
runtime error: file common.xsl line 112 element apply-templates
The 'select' expression did not evaluate to a node set.
Comment 1 Al Thomas 2017-03-13 12:12:48 UTC 
Line 112 of common.xsl is currently:
    <tr><td>Vala version:</td><td><xsl:apply-templates select="str:replace(edition, '-', '')"/></td></tr>

The release notes for xsltproc (http://xmlsoft.org/XSLT/news.html) state that version 1.1.27 (released 12 Sept 2012) included the bug fix:
Rewrite EXSLT string:replace to be conformant 

Hopefully that is the bug fix needed. So that would mean the minimum version of xsltproc we need is 1.1.27. That release is already over four years old. 1.1.26 was released 24 Sept 2009. Do we really need to try and workaround a bug in a version from over seven years ago?
Comment 2 Rico Tzschichholz 2017-03-13 12:31:46 UTC 
I just noticed it when building on Ubuntu 12.04 which only has 1.1.26, although its support will end in about a month (2017-04-26).
Comment 3 Rico Tzschichholz 2017-03-13 12:56:58 UTC 
commit 54ceaec3c86aa4fb1735ed18e7b2ed27112ba335
Author: Rico Tzschichholz <ricotz@ubuntu.com>
Date:   Mon Mar 13 13:53:59 2017 +0100

    Introduce $API_VERSION as base for $PACKAGE_SUFFIX and for usage in manual
    
    This goes along with unbreaking the manual-build with libxslt < 1.1.27.