After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779943 - Git URL with spaces at the start or end gives "malformed url"
Git URL with spaces at the start or end gives "malformed url"
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
Flatpak Nightly Channel
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-12 16:09 UTC by Carlos Soriano
Modified: 2017-03-12 22:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
git: strip URI strings of space characters (2.65 KB, patch)
2017-03-12 22:00 UTC, Christian Hergert 		committed Details | Review

Description Carlos Soriano 2017-03-12 16:09:38 UTC 
So sometimes in wikis, etc. there are chances that you copy one space more than necessary. This gives an error saying "malformed URL" in the greeter when trying to clone.

I guess builder should clean it up before parsing.
Comment 1 Christian Hergert 2017-03-12 22:00:31 UTC 
Created attachment 347776 [details] [review]
git: strip URI strings of space characters

We should be able to trim the space altogether from URI strings since they
shouldn't be valid anywhere in the URI. This handles paste, entry, and if
somehow it managed to get space in there by defensively stripping before
URI creation.
Comment 2 Christian Hergert 2017-03-12 22:01:21 UTC 
Attachment 347776 [details] pushed as 2287054 - git: strip URI strings of space characters