GNOME Bugzilla – Bug 779927
Don't show the "Next" button when selecting POI type for OSM object
Last modified: 2017-04-03 21:37:32 UTC
When in the edit OpenStreetMap data dialog, the "Next" button is still visible when selecting a POI type, leading to some incosistent state. To reproduce: Select "Add to OpenStreetMap, write something in the "Name" field (to enable the "Next" button), click on the type button to enter the type selection page, now instead of selecting a type, click the "Next" button. Now the dialog switches to the upload page (where you'd enter an edit comment) while still showing the "Select type" heading. I think it would be better to hide the "Next" button when in the type selection page, and only allow either selecting a type, or clicking the back button (to cancel the type selection).
Created attachment 347738 [details] [review] osmEditDialog: Hide "Next" button when selecting type Hide the "Next" button in the dialog when showing the POI type-selection page.
Review of attachment 347738 [details] [review]: LGTM!
Attachment 347738 [details] pushed as fc26fdb - osmEditDialog: Hide "Next" button when selecting type
(In reply to Mattias Bengtsson from comment #2) > Review of attachment 347738 [details] [review] [review]: > > LGTM! Thanks for the review! :)