After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779927 - Don't show the "Next" button when selecting POI type for OSM object
Don't show the "Next" button when selecting POI type for OSM object
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-12 08:13 UTC by Marcus Lundblad
Modified: 2017-04-03 21:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
osmEditDialog: Hide "Next" button when selecting type (1.57 KB, patch)
2017-03-12 08:13 UTC, Marcus Lundblad
committed Details | Review

Description Marcus Lundblad 2017-03-12 08:13:10 UTC
When in the edit OpenStreetMap data dialog, the "Next" button is still visible when selecting a POI type, leading to some incosistent state. To reproduce: Select "Add to OpenStreetMap, write something in the "Name" field (to enable the "Next" button), click on the type button to enter the type selection page, now instead of selecting a type, click the "Next" button. Now the dialog switches to the upload page (where you'd enter an edit comment) while still showing the "Select type" heading. I think it would be better to hide the "Next" button when in the type selection page, and only allow either selecting a type, or clicking the back button (to cancel the type selection).
Comment 1 Marcus Lundblad 2017-03-12 08:13:43 UTC
Created attachment 347738 [details] [review]
osmEditDialog: Hide "Next" button when selecting type

Hide the "Next" button in the dialog when showing the POI type-selection
page.
Comment 2 Mattias Bengtsson 2017-04-03 21:01:22 UTC
Review of attachment 347738 [details] [review]:

LGTM!
Comment 3 Marcus Lundblad 2017-04-03 21:36:04 UTC
Attachment 347738 [details] pushed as fc26fdb - osmEditDialog: Hide "Next" button when selecting type
Comment 4 Marcus Lundblad 2017-04-03 21:37:32 UTC
(In reply to Mattias Bengtsson from comment #2)
> Review of attachment 347738 [details] [review] [review]:
> 
> LGTM!

Thanks for the review! :)