After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779906 - roomManager: Add account parameter to lookupRoomByName()
roomManager: Add account parameter to lookupRoomByName()
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-11 15:44 UTC by Florian Müllner
Modified: 2017-03-13 02:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
roomManager: Add account parameter to lookupRoomByName() (2.62 KB, patch)
2017-03-11 15:44 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-03-11 15:44:10 UTC
See patch.
Comment 1 Florian Müllner 2017-03-11 15:44:15 UTC
Created attachment 347707 [details] [review]
roomManager: Add account parameter to lookupRoomByName()

Room names are only unique within a network, so we need an additional
account parameter to unequivocally identify a room. Being able to
/part rooms from any network may arguably be handy (yet unexpected),
but we really need to identify the correct room in the other case
where we match by room name:
The join dialog's room list presents already joined rooms as checked
but insensitive, so it is currently impossible to pick a room that
is joined on a different network.
Comment 2 Florian Müllner 2017-03-13 02:49:23 UTC
Attachment 347707 [details] pushed as 1ae1d7e - roomManager: Add account parameter to lookupRoomByName()