GNOME Bugzilla – Bug 779905
build: Add a first version of Flatpak manifest
Last modified: 2017-04-11 07:35:33 UTC
See patch, reviewed by Christian. It's a first version since no portals are used (so the link to the music folder dosn't work for example) but I hope enough to allow contributors using flapak from inside gnome-builder.
Created attachment 347706 [details] [review] build: Add a first version of Flatpak manifest Still need to make load some files, but at least it runs!
Created attachment 347948 [details] [review] gnome-music.desktop: Rename desktop file Up until now we were using gnome-music.desktop as name for the desktop file. However this is discouraged since it's not using a unique id similar to dbus addresses. This also bring the problem that to build with flatpak the desktop file has to match the dbus address. So simply rename the desktop file to org.gnome.Music.org
Created attachment 347949 [details] [review] build: Add a first version of Flatpak manifest So it can be used by devs to build against in GNOME Builder.
Review of attachment 347948 [details] [review]: Looks fine.
Review of attachment 347949 [details] [review]: ::: org.gnome.Music.json @@ +81,3 @@ + { + "name": "grilo-plugins", + "config-opts": [ "--enable-tracker", "--enable-dleyna" ], You'll want to explicitely disable the plugins you don't need. @@ +99,3 @@ + { + "type": "file", + "path": "py-configure", Is that doing "pip3 install"? That won't work in flatpak-builder, which doesn't have network access.
(In reply to Bastien Nocera from comment #5) > Review of attachment 347949 [details] [review] [review]: > > ::: org.gnome.Music.json > @@ +81,3 @@ > + { > + "name": "grilo-plugins", > + "config-opts": [ "--enable-tracker", "--enable-dleyna" ], > > You'll want to explicitely disable the plugins you don't need. You mean for the ones that are not by default on I should disable then? > > @@ +99,3 @@ > + { > + "type": "file", > + "path": "py-configure", > > Is that doing "pip3 install"? That won't work in flatpak-builder, which > doesn't have network access. Yes, I took it from pitivy, but indeed that makes sense... I will change that.
Created attachment 348104 [details] [review] build: Add a first version of Flatpak manifest So it can be used by devs to build against in GNOME Builder.
Created attachment 348105 [details] [review] build: Add a first version of Flatpak manifest So it can be used by devs to build against in GNOME Builder.
Review of attachment 348105 [details] [review]: Looks good to me. You might want to tweak the grilo plugins, especially the lack of goa support might be a problem for later features.
Marinus or Felipe can you ack this?
While testing here, it fails to build the "requests" module. Error: module requests: Can't find autogen, autogen.sh or Xbootstrap It should be build with pip or setup.py (which I think flatpak does not support).
(In reply to Felipe Borges from comment #11) > While testing here, it fails to build the "requests" module. > > Error: module requests: Can't find autogen, autogen.sh or Xbootstrap > > It should be build with pip or setup.py (which I think flatpak does not > support). the last version? The manifest builds the requests module. It needs Flatpak 0.9.1 for the simple-build system.
(In reply to Carlos Soriano from comment #12) > the last version? The manifest builds the requests module. It needs Flatpak > 0.9.1 for the simple-build system. ahaa! it works like a sharm! Lgtm
Attachment 347948 [details] pushed as 26cbbe1 - gnome-music.desktop: Rename desktop file Attachment 348105 [details] pushed as 400fbe9 - build: Add a first version of Flatpak manifest
Music pushed the renamed patch
ugh, git bz confused the bug it has to comment on :(
for reference, the gnome-shell counterpart https://bugzilla.gnome.org/show_bug.cgi?id=780157 is pushed now too
Heya, sorry I didn't mention in here, this was supposedly to happen after branching. Got a few reports from Jeremy Bicha and Michael Catanzaro. Can it be reverted in master, do a 3.24.1.1 release, then branch and commit this to master again?