After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779901 - hotkeys alt + home go home page
hotkeys alt + home go home page
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Controls
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-11 14:04 UTC by what103
Modified: 2017-03-12 02:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add Alt+Home to key event blacklist (1023 bytes, patch)
2017-03-11 18:10 UTC, Michael Catanzaro
committed Details | Review

Description what103 2017-03-11 14:04:40 UTC
hello again.

add pls [alt+home] go to home page. is good if work in full screen.
thanks.
Comment 1 André Klapper 2017-03-11 14:23:25 UTC
Please provide steps to reproduce how you set a "home page" in Epiphany.
Please always provide version information in all bug reports.
Comment 2 what103 2017-03-11 15:54:03 UTC
(In reply to André Klapper from comment #1)
> Please provide steps to reproduce how you set a "home page" in Epiphany.
> Please always provide version information in all bug reports.

my home page about:overview in Preferences/Home page/Custom . i look in Menu/Keyboard Shortcuts and see ctrl+T it new tab, but some browser have alt+Home for go home page in use tab without new tab is very usability hotkey.
Comment 3 Michael Catanzaro 2017-03-11 18:03:53 UTC
We already have this shortcut, but it seems to be broken.
Comment 4 Michael Catanzaro 2017-03-11 18:07:27 UTC
OK, it only works if the location entry is focused, because WebKit always eats the key event.
Comment 5 Michael Catanzaro 2017-03-11 18:10:01 UTC
(This also makes it work when it is fullscreen.)
Comment 6 Michael Catanzaro 2017-03-11 18:10:46 UTC
The following fix has been pushed:
9235ad3 Add Alt+Home to key event blacklist
Comment 7 Michael Catanzaro 2017-03-11 18:10:50 UTC
Created attachment 347719 [details] [review]
Add Alt+Home to key event blacklist

WebKit always handles this key press event, so our Alt+Home shortcut
does not work if the web view is focused... which is pretty much always.
Fix that.
Comment 8 what103 2017-03-11 18:13:01 UTC
(In reply to Michael Catanzaro from comment #3)
> We already have this shortcut

and in Menu/Keyboard Shortcuts?
Comment 9 Michael Catanzaro 2017-03-11 19:38:59 UTC
(In reply to what103 from comment #8)
> (In reply to Michael Catanzaro from comment #3)
> > We already have this shortcut
> 
> and in Menu/Keyboard Shortcuts?

Bug #779916.
Comment 10 what103 2017-03-12 02:58:34 UTC
(In reply to Michael Catanzaro from comment #9)
> (In reply to what103 from comment #8)
> > (In reply to Michael Catanzaro from comment #3)
> > > We already have this shortcut
> > 
> > and in Menu/Keyboard Shortcuts?
> 
> Bug #779916.

cool! thank you