After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779867 - gnome-maps js warning on start that it will run very slowly.
gnome-maps js warning on start that it will run very slowly.
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-10 16:08 UTC by Hussam Al-Tayeb
Modified: 2017-06-26 19:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xmldom: Remove __proto__ accessor (1.01 KB, patch)
2017-05-22 20:44 UTC, Marcus Lundblad
committed Details | Review

Description Hussam Al-Tayeb 2017-03-10 16:08:07 UTC
I see this warning on starting gnome-maps. It does indeed take a while to start (corei5 skylake processor with 8GB ram).

Gjs-Message: JS WARNING: [resource:///org/gnome/Maps/js/xmldom/dom.js 21]: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create
Comment 1 Jeremy Bicha 2017-03-14 02:44:46 UTC
I also see the warning with gnome-maps 3.23.92-0ubuntu1 using gjs 1.47.92-0ubuntu1 on Ubuntu GNOME 17.04 Beta.
Comment 2 Hussam Al-Tayeb 2017-03-14 07:35:42 UTC
Marcus said this is an issue in imported code from https://github.com/jindw/xmldom
I filed a bug report there:
https://github.com/jindw/xmldom/issues/202
Comment 3 Marcus Lundblad 2017-05-22 20:44:28 UTC
Created attachment 352380 [details] [review]
xmldom: Remove __proto__ accessor

This is based on a change in upstream change. I kinda gave up on importing
the new upstream files, as we did some patching previously, and just
using the verbatim upstream files gives errors and warnings.
At least, with this change loading GPX and KML layers still seem to work
fine.
Comment 4 Marcus Lundblad 2017-06-26 19:51:35 UTC
Attachment 352380 [details] pushed as af5cd9e - xmldom: Remove __proto__ accessor