GNOME Bugzilla – Bug 779820
Some date+time drop-down improvements
Last modified: 2017-07-12 14:52:01 UTC
Some tweaks, based on designer review of the recent notification refresh.
Created attachment 347580 [details] [review] dateMenu: Add some spacing between displays Now that we have more than just the "World Clocks" display, it turns out we need some spacing between sections.
Created attachment 347581 [details] [review] dateMenu: Add vertical separator between message list and calendar With the background boxes gone from messages, we need some visual indication for how elements are aligned.
Created attachment 347582 [details] [review] calendar: Fake baseline alignment for notification timestamp We don't have GTK's baseline alignment, so all we can do is add some padding and hope it works out fine for most fonts and sizes ...
Created attachment 347583 [details] [review] mpris: Add hover effect It is not immediately obvious that media controls are interactive, so add a small hover effect.
If they're designer acked go ahead and push!
I was wondering why my sass tweaks to the separator line were overwriting the stylesheet... These patches are only for the generated CSS. These changes look ok, but I would like to have the source SCSS to be able to build on top of it and fix the separator line.
(In reply to Jakub Steiner from comment #6) > I was wondering why my sass tweaks to the separator line were overwriting > the stylesheet... These patches are only for the generated CSS. Yeah, it's generally easier for reviewers to not having to deal with sass. https://paste.gnome.org/prgw5sbh1 has the patch series for the scss.
Attachment 347580 [details] pushed as 3d39979 - dateMenu: Add some spacing between displays Attachment 347582 [details] pushed as af18a0c - calendar: Fake baseline alignment for notification timestamp Attachment 347583 [details] pushed as e907349 - mpris: Add hover effect
The "remaining" patch actually landed as well, so nothing left on this bug ... Attachment 347581 [details] pushed as 50df308 - dateMenu: Add vertical separator between message list and calendar