After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779820 - Some date+time drop-down improvements
Some date+time drop-down improvements
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-09 22:01 UTC by Florian Müllner
Modified: 2017-07-12 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dateMenu: Add some spacing between displays (1.32 KB, patch)
2017-03-09 22:02 UTC, Florian Müllner
committed Details | Review
dateMenu: Add vertical separator between message list and calendar (1.61 KB, patch)
2017-03-09 22:02 UTC, Florian Müllner
committed Details | Review
calendar: Fake baseline alignment for notification timestamp (1.65 KB, patch)
2017-03-09 22:02 UTC, Florian Müllner
committed Details | Review
mpris: Add hover effect (1.69 KB, patch)
2017-03-09 22:02 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-03-09 22:01:59 UTC
Some tweaks, based on designer review of the recent notification refresh.
Comment 1 Florian Müllner 2017-03-09 22:02:04 UTC
Created attachment 347580 [details] [review]
dateMenu: Add some spacing between displays

Now that we have more than just the "World Clocks" display, it turns
out we need some spacing between sections.
Comment 2 Florian Müllner 2017-03-09 22:02:09 UTC
Created attachment 347581 [details] [review]
dateMenu: Add vertical separator between message list and calendar

With the background boxes gone from messages, we need some visual
indication for how elements are aligned.
Comment 3 Florian Müllner 2017-03-09 22:02:15 UTC
Created attachment 347582 [details] [review]
calendar: Fake baseline alignment for notification timestamp

We don't have GTK's baseline alignment, so all we can do is add some
padding and hope it works out fine for most fonts and sizes ...
Comment 4 Florian Müllner 2017-03-09 22:02:20 UTC
Created attachment 347583 [details] [review]
mpris: Add hover effect

It is not immediately obvious that media controls are interactive,
so add a small hover effect.
Comment 5 Rui Matos 2017-03-10 16:33:04 UTC
If they're designer acked go ahead and push!
Comment 6 Jakub Steiner 2017-03-13 22:46:11 UTC
I was wondering why my sass tweaks to the separator line were overwriting the stylesheet... These patches are only for the generated CSS.

These changes look ok, but I would like to have the source SCSS to be able to build on top of it and fix the separator line.
Comment 7 Florian Müllner 2017-03-13 23:08:49 UTC
(In reply to Jakub Steiner from comment #6)
> I was wondering why my sass tweaks to the separator line were overwriting
> the stylesheet... These patches are only for the generated CSS.

Yeah, it's generally easier for reviewers to not having to deal with sass. https://paste.gnome.org/prgw5sbh1 has the patch series for the scss.
Comment 8 Florian Müllner 2017-03-14 14:24:49 UTC
Attachment 347580 [details] pushed as 3d39979 - dateMenu: Add some spacing between displays
Attachment 347582 [details] pushed as af18a0c - calendar: Fake baseline alignment for notification timestamp
Attachment 347583 [details] pushed as e907349 - mpris: Add hover effect
Comment 9 Florian Müllner 2017-07-12 14:51:56 UTC
The "remaining" patch actually landed as well, so nothing left on this bug ...

Attachment 347581 [details] pushed as 50df308 - dateMenu: Add vertical separator between message list and calendar