After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779715 - Two 256px icons dropped in 3.23.91 without a 512px replacement
Two 256px icons dropped in 3.23.91 without a 512px replacement
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: adwaita-icon-theme maintainer(s)
adwaita-icon-theme maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-07 18:25 UTC by Jeremy Bicha
Modified: 2017-09-26 14:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fullcolor: revert deletion of 2 256px icons w/o 512 replacement (59.48 KB, patch)
2017-03-09 23:45 UTC, Jeremy Bicha
none Details | Review
fullcolor: add missing highres (1.02 MB, patch)
2017-03-10 11:16 UTC, Jakub Steiner
committed Details | Review

Description Jeremy Bicha 2017-03-07 18:25:08 UTC
By doing a diff or 3.23.91 against 3.22 as part of my work to update adwaita-icon-theme in Ubuntu ( https://launchpad.net/bugs/1669158 ), I found that 2 icons had their 256px versions dropped without having 512px versions added:

mimetypes/x-office-presentation.png
mimetypes/x-office-address-book.png

Both were part of this massive commit so it looks accidental:

https://git.gnome.org/browse/adwaita-icon-theme/commit/Adwaita/256x256/mimetypes?id=d93cb727b309745a283304b7a87211c9ddeaa6fb

https://git.gnome.org/browse/adwaita-icon-theme/commit/Adwaita/512x512/mimetypes?id=d93cb727b309745a283304b7a87211c9ddeaa6fb
Comment 1 Jeremy Bicha 2017-03-09 23:45:02 UTC
Created attachment 347589 [details] [review]
fullcolor: revert deletion of 2 256px icons w/o 512 replacement

Patch attached
Comment 2 Jakub Steiner 2017-03-10 11:16:44 UTC
Created attachment 347616 [details] [review]
fullcolor: add missing highres

- in the mimetype refresh, some icons were left out
Comment 3 Jakub Steiner 2017-03-10 11:17:11 UTC
Comment on attachment 347616 [details] [review]
fullcolor: add missing highres

Attachment 347616 [details] pushed as e38bb3d - fullcolor: add missing highres