GNOME Bugzilla – Bug 779678
terminal: missing shell causes execvp error when executing in runtimes
Last modified: 2017-03-06 22:56:03 UTC
Snip ===== The shortcut ctrl + alt + shift + t does not work. There is a "unknown terminal" which disappears instant (like 0.2 secs). "execvp /usr/bin/fish: No such file or directory" I switched my default shell back to bash. Now it's working. End =====
Created attachment 347344 [details] [review] terminal: don't use runtime for preferred shell discover This is more likely to make us end up with something like /bin/sh if we try to run getent from within the runtime.
Created attachment 347345 [details] [review] terminal: remove use of GPtrArray for single element We don't need the GPtrArray because we only had a single element in it anyway (plus NULL terminator). Just use the push_argv() helper.
Created attachment 347346 [details] [review] terminal: fallback to /bin/bash when necessary All the runtimes today thus far have bash, so just depend on that if we do not have the preferred shell in the runtime (say its zsh, fish, etc).
Attachment 347344 [details] pushed as c1f8912 - terminal: don't use runtime for preferred shell discover Attachment 347345 [details] pushed as e0dcecc - terminal: remove use of GPtrArray for single element Attachment 347346 [details] pushed as 658c0ba - terminal: fallback to /bin/bash when necessary