After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779624 - Add javascript linting using eslint
Add javascript linting using eslint
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-05 18:46 UTC by georg.vienna
Modified: 2017-03-07 04:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eslint plugin: add javascript linting using eslint (11.40 KB, patch)
2017-03-05 18:48 UTC, georg.vienna
committed Details | Review

Description georg.vienna 2017-03-05 18:46:42 UTC
Hello again,

this time I'm adding javascript linting using eslint.
It is a simple plugin to get the diagnostics of a javascript file from eslint.
To use it eslint must be installed and a eslint configuration file needs to be in the project directory.

It is disabled by default, so it won't impact normal users.

Thanks,
Georg
Comment 1 georg.vienna 2017-03-05 18:48:20 UTC
Created attachment 347275 [details] [review]
eslint plugin: add javascript linting using eslint

This adds support for linting javascript files using eslint.
An eslint configuration file must be present in the project directory.

http://eslint.org/
Comment 2 Christian Hergert 2017-03-07 04:00:19 UTC
Review of attachment 347275 [details] [review]:

Excellent work! We probably need to come up with a strategy to let the user know we couldn't find eslint. But we don't have a good place to show the user that yet. Maybe underneath the preference. Although that will be complicated in that it will require checking per-runtime, rather than globally.
Comment 3 Christian Hergert 2017-03-07 04:00:57 UTC
Attachment 347275 [details] pushed as 548fef6 - eslint plugin: add javascript linting using eslint