GNOME Bugzilla – Bug 779619
new libmediaart 1.9.1 symbols look wrong
Last modified: 2021-05-25 11:25:43 UTC
These new symbols look wrong to me (the extra _VOID__STRING* stuff) media_art_file_to_jpeg@Base 1.9.0 media_art_get_file@Base 1.9.0 media_art_get_path@Base 1.9.0 + media_art_marshal_VOID__STRING_STRING@Base 1.9.1 + media_art_marshal_VOID__STRING_STRING_STRING_BOOLEAN_BOOLEAN@Base 1.9.1 media_art_plugin_init@Base 1.9.0 media_art_plugin_shutdown@Base 1.9.0 media_art_process_buffer@Base 1.9.0
Those are generated by marshal.list. I would suggest using a underscore like --prefix=_media_art_marshal so those symbols are hidden
Oh, I see my change was reverted in 52eb6498c97ce0005186946bc9162d87597abc2c
(In reply to Michael Biebl from comment #2) > Oh, I see my change was reverted in 52eb6498c97ce0005186946bc9162d87597abc2c Well, partially at least @Martin which build failure did you run into? We shipped this patch [1] in Debian for a while without problems. [1] https://anonscm.debian.org/cgit/collab-maint/libmediaart.git/tree/debian/patches/0001-build-hide-private-symbols.patch
One issue I notice (which was probably an oversight on my part) is: ./libmediaart-sections.txt:44: warning: No declaration found for media_art_marshal_VOID__STRING_STRING. ./libmediaart-sections.txt:45: warning: No declaration found for media_art_marshal_VOID__STRING_STRING_STRING_BOOLEAN_BOOLEAN. See libmediaart-undeclared.txt for the list of undeclared symbols. I would remove that section from docs/reference/libmediaart/libmediaart-sections.txt: <SECTION> <FILE>marshal</FILE> media_art_marshal_VOID__STRING_STRING media_art_marshal_VOID__STRING_STRING_STRING_BOOLEAN_BOOLEAN </SECTION>
Can't we just use the FFI marshaller here?
Martin, can you chime in here please?
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new enhancement request ticket at https://gitlab.gnome.org/GNOME/libmediaart/-/issues/ Thank you for your understanding and your help.