After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779589 - Emit GdMainBox::selection-changed only after updating the selection
Emit GdMainBox::selection-changed only after updating the selection
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-04 19:55 UTC by Debarshi Ray
Modified: 2017-03-06 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main-box, main-icon-box: Emit selection-changed with updated selection (4.73 KB, patch)
2017-03-05 11:47 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2017-03-04 19:55:14 UTC
Deleting an item from the selection mode leads to:

** (gnome-photos:7800): CRITICAL **: photos_base_item_can_trash: assertion 'PHOTOS_IS_BASE_ITEM (self)' failed

** (gnome-photos:7800): CRITICAL **: photos_base_item_get_default_app_name: assertion 'PHOTOS_IS_BASE_ITEM (self)' failed

(gnome-photos:7800): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(gnome-photos:7800): GLib-GObject-CRITICAL **: g_signal_connect_object: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(gnome-photos:7800): GLib-GObject-CRITICAL **: g_object_ref: assertion 'G_IS_OBJECT (object)' failed

** (gnome-photos:7800): CRITICAL **: photos_base_item_is_collection: assertion 'PHOTOS_IS_BASE_ITEM (self)' failed

** (gnome-photos:7800): CRITICAL **: photos_base_item_is_collection: assertion 'PHOTOS_IS_BASE_ITEM (self)' failed

** (gnome-photos:7800): CRITICAL **: photos_base_item_is_favorite: assertion 'PHOTOS_IS_BASE_ITEM (self)' failed

** (gnome-photos:7800): CRITICAL **: photos_base_item_get_default_app_name: assertion 'PHOTOS_IS_BASE_ITEM (self)' failed

(gnome-photos:7800): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(gnome-photos:7800): GLib-GObject-CRITICAL **: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed

(gnome-photos:7800): GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
Comment 1 Debarshi Ray 2017-03-05 11:45:04 UTC
Reassigning from gnome-photos to libgd.
Comment 2 Debarshi Ray 2017-03-05 11:47:11 UTC
(In reply to Debarshi Ray from comment #0)
> Deleting an item from the selection mode leads to:

It also happens if the item behind a selected widget is deleted out-of-band. eg., from Files.

This is caused by GdMainBox::selection-changed being emitted before the list of selected child widgets got updated.
Comment 3 Debarshi Ray 2017-03-05 11:47:35 UTC
Created attachment 347263 [details] [review]
main-box, main-icon-box: Emit selection-changed with updated selection
Comment 4 Cosimo Cecchi 2017-03-05 23:52:35 UTC
Review of attachment 347263 [details] [review]:

Looks good to me.
Comment 5 Debarshi Ray 2017-03-06 00:06:33 UTC
Comment on attachment 347263 [details] [review]
main-box, main-icon-box: Emit selection-changed with updated selection

Thanks for another quick review, Cosimo. Pushed to master.