GNOME Bugzilla – Bug 779585
Window is wider than 1024px
Last modified: 2017-03-13 22:01:29 UTC
I'm attaching a few patches I had lingering that allow gnome-music to have a smaller size requisition, thus fitting easily in 1024px wide screens (my usecase is hidpi 2160px wide screen though) It turns out it's the treeview(s) which are making the window larger than it could, boils down to some clunky packing of cell renderers in treeview columns, and some fixed sizes to compensate for it. The patches basically put the star cell renderer into its own column so treeview knows better how to do proper size distribution, and then removes the fixed sizes over the place.
Created attachment 347228 [details] [review] starhandlerwidget: Specify the column to add the cell renderer to Instead of assuming it is OK to append itself to cols[0], allow the caller to specify the column that will receive the cell renderer.
Created attachment 347229 [details] [review] songsview: Drop hardcoded widths This makes content further shrinkable, and thus gnome-music friendlier on not-that-wide screens. The star cell renderer has been separated into another column, as there is better size management across columns than inside them, the cell renderer might appear at an inconsistent place otherwise.
Makes sense, lgtm & thanks for the patches. Attachment 347228 [details] pushed as 968f7eb - starhandlerwidget: Specify the column to add the cell renderer to Attachment 347229 [details] pushed as 1eed02d - songsview: Drop hardcoded widths