After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779585 - Window is wider than 1024px
Window is wider than 1024px
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks: 778870
 
 
Reported: 2017-03-04 18:41 UTC by Carlos Garnacho
Modified: 2017-03-13 22:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
starhandlerwidget: Specify the column to add the cell renderer to (3.71 KB, patch)
2017-03-04 18:42 UTC, Carlos Garnacho
committed Details | Review
songsview: Drop hardcoded widths (3.18 KB, patch)
2017-03-04 18:42 UTC, Carlos Garnacho
committed Details | Review

Description Carlos Garnacho 2017-03-04 18:41:39 UTC
I'm attaching a few patches I had lingering that allow gnome-music to have a smaller size requisition, thus fitting easily in 1024px wide screens (my usecase is hidpi 2160px wide screen though)

It turns out it's the treeview(s) which are making the window larger than it could, boils down to some clunky packing of cell renderers in treeview columns, and some fixed sizes to compensate for it.

The patches basically put the star cell renderer into its own column so treeview knows better how to do proper size distribution, and then removes the fixed sizes over the place.
Comment 1 Carlos Garnacho 2017-03-04 18:42:15 UTC
Created attachment 347228 [details] [review]
starhandlerwidget: Specify the column to add the cell renderer to

Instead of assuming it is OK to append itself to cols[0], allow the
caller to specify the column that will receive the cell renderer.
Comment 2 Carlos Garnacho 2017-03-04 18:42:21 UTC
Created attachment 347229 [details] [review]
songsview: Drop hardcoded widths

This makes content further shrinkable, and thus gnome-music friendlier
on not-that-wide screens. The star cell renderer has been separated
into another column, as there is better size management across columns
than inside them, the cell renderer might appear at an inconsistent
place otherwise.
Comment 3 Marinus Schraal 2017-03-13 22:01:21 UTC
Makes sense, lgtm & thanks for the patches.

Attachment 347228 [details] pushed as 968f7eb - starhandlerwidget: Specify the column to add the cell renderer to
Attachment 347229 [details] pushed as 1eed02d - songsview: Drop hardcoded widths