After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779574 - other favourite apps settings not saved
other favourite apps settings not saved
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: application
1.6.x
Other Linux
: Normal normal
: 1.6
Assigned To: GNOME Commander maintainer(s)
GNOME Commander maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-04 15:18 UTC by moon300web
Modified: 2017-03-06 23:25 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description moon300web 2017-03-04 15:18:59 UTC
Trying to add programs via:
Settings - options - programs - other favourite apps

If you do *not* set a pattern or icon, so that the 
.gnome-commander/fav-apps file does not contain:
...
icon=/usr/share/icons/hicolor/scalable/apps/file-roller-symbolic.svg
...
pattern=*

The settings are saved, but they are not loaded, because the corresponding key will be missing.
And hence the added programs do not show up.

Solution: 
- make icon setting an obligation
- If you set the pattern to * and only afterwards change
'Show for' to e.g. 'all files', then the file keeps on containing pattern=* and hence loading goes OK
Comment 1 Ken 2017-03-04 22:39:33 UTC
I can confirm this bug in Gnome-commander 1.6.2 running on CentOS 7.3 + X Windows system + Mate desktop. I also noted that a space between patterns e.g. "*.jpg;*.jpeg; *.gif" will cause issues. In this case .gif files are not offered the favorite application.

Ken Taylor
Comment 2 Uwe Scholz 2017-03-05 20:35:44 UTC
Thank you very much for taking the time to report this bug. I could also reproduce it and fixed it in commit 8c5711bb. The problem was a char pointer pointing to null when storing fav-apps after no icon was chosen in the options dialogue.

The fix will go into the next bugfix release of Gnome Commander.

@Ken: Regarding "*.jpg;*.jpeg; *.gif": This is desired behaviour as this pattern results in only affecting those gif-files with a space-character as the first character in their file name.
Comment 3 Ken 2017-03-05 22:37:05 UTC
Thanks Uwe,

Looks like regular expressions strike again :-(   I tend to be somewhat irregular :-)

Ken
Comment 4 moon300web 2017-03-06 23:25:02 UTC
Thanks for fixing Uwe!