After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779551 - Build failure in Continuous
Build failure in Continuous
Status: RESOLVED FIXED
Product: gexiv2
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gexiv2 Maintainers
Gexiv2 Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-03 20:41 UTC by Emmanuele Bassi (:ebassi)
Modified: 2017-03-03 21:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix accidental c++11ism (925 bytes, patch)
2017-03-03 20:55 UTC, Jens Georg 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2017-03-03 20:41:44 UTC 
gexiv2 fails to build in GNOME Continuous with this error:

../gexiv2/gexiv2-metadata-gps.cpp: In function 'double convert_rational(const Rational&)':
../gexiv2/gexiv2-metadata-gps.cpp:32:5: warning: 'auto' changes meaning in C++11; please remove it [-Wc++0x-compat]
     auto num = static_cast<double>(r.first);
     ^
../gexiv2/gexiv2-metadata-gps.cpp:32:10: error: 'num' does not name a type
     auto num = static_cast<double>(r.first);
          ^
../gexiv2/gexiv2-metadata-gps.cpp:33:5: warning: 'auto' changes meaning in C++11; please remove it [-Wc++0x-compat]
     auto den = static_cast<double>(r.second);
     ^
../gexiv2/gexiv2-metadata-gps.cpp:33:10: error: 'den' does not name a type
     auto den = static_cast<double>(r.second);
          ^
../gexiv2/gexiv2-metadata-gps.cpp:35:12: error: 'num' was not declared in this scope
     return num / den;
            ^
../gexiv2/gexiv2-metadata-gps.cpp:35:18: error: 'den' was not declared in this scope
     return num / den;
                  ^
Comment 1 Emmanuele Bassi (:ebassi) 2017-03-03 20:42:02 UTC 
See full build log at:

http://build.gnome.org/continuous/buildmaster/builds/2017/03/03/53/build/log-gexiv2.txt
Comment 2 Jens Georg 2017-03-03 20:53:25 UTC 
which ancient compiler is continous running?
Comment 3 Jens Georg 2017-03-03 20:55:54 UTC 
Created attachment 347167 [details] [review]
Fix accidental c++11ism

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 4 Jens Georg 2017-03-03 20:56:13 UTC 
Attachment 347167 [details] pushed as 325ec93 - Fix accidental c++11ism
Comment 5 Emmanuele Bassi (:ebassi) 2017-03-03 20:59:25 UTC 
Continuous is running with GCC 4.9; we can probably bump it up to 5.something, but it'll take a little while.
Comment 6 Emmanuele Bassi (:ebassi) 2017-03-03 21:04:48 UTC 
Actually, no: we're already running with GCC 5.3. Can't update to anything newer without a larger rebase of the whole base OS.
Comment 7 Jens Georg 2017-03-03 21:14:43 UTC 
That's fine, when using C++11 the configure script should probably check whether the compiler supports it OOTB or needs some flags.