After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779542 - build: Add pangocairo and cogl-pango-1.0 to *_gir_PACKAGES
build: Add pangocairo and cogl-pango-1.0 to *_gir_PACKAGES
Status: RESOLVED FIXED
Product: libchamplain
Classification: Core
Component: bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libchamplain-maint
libchamplain-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-03 15:02 UTC by Debarshi Ray
Modified: 2017-03-05 18:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Add pangocairo and cogl-pango-1.0 to *_gir_PACKAGES (2.23 KB, patch)
2017-03-03 15:04 UTC, Debarshi Ray 		none Details | Review

Description Debarshi Ray 2017-03-03 15:02:22 UTC 
In Red Hat Enterprise Linux 7.3, we have been shipping the attached patch with libchamplain-0.12.4. Apparently it fixed a build failure at some point. Interestingly, it is no longer needed with libchamplain-0.12.14.

I have very little knowledge of this, but a quick grep says that the upstream Makefile.ams use pangocairo and cogl-pango-1.0 to create the vapi files, but are missing from *_gir_PACKAGES. Maybe they should be added there? Maybe something is masking the build failure now?

Please accept my apologies, if the patch is a mistake.
Comment 1 Debarshi Ray 2017-03-03 15:04:00 UTC 
Created attachment 347146 [details] [review]
build: Add pangocairo and cogl-pango-1.0 to *_gir_PACKAGES
Comment 2 Jiri Techet 2017-03-05 18:28:10 UTC 
The problem is probably reproducible only with some combinations of dependency versions (couldn't reproduce myself). But there should be no problem with having the extra libraries in _PACKAGES so why not.

I've just committed the patch, thanks.