After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779462 - Several bugs spotted by coverity
Several bugs spotted by coverity
Status: RESOLVED FIXED
Product: msitools
Classification: Other
Component: gcab
git
Other Linux
: Normal normal
: 1.0
Assigned To: msitools maintainer(s)
msitools maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-02 09:33 UTC by Richard Hughes
Modified: 2017-03-03 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for review #1 (1.74 KB, patch)
2017-03-02 09:34 UTC, Richard Hughes 		committed Details | Review
patch for review #2 (992 bytes, patch)
2017-03-02 09:34 UTC, Richard Hughes 		committed Details | Review
patch for review #3 (912 bytes, patch)
2017-03-02 09:34 UTC, Richard Hughes 		committed Details | Review
patch for review #4 (941 bytes, patch)
2017-03-02 09:35 UTC, Richard Hughes 		committed Details | Review

Description Richard Hughes 2017-03-02 09:33:55 UTC 
I've attached 4 patches that fix bugs spotted by coverity. The first two are pretty obvious. The 2nd two are more tricky, and probably need some careful review. I'm not a huge expert in the PKZIP Huffman table generation scene, and the patches probably reflect this. :)
Comment 1 Richard Hughes 2017-03-02 09:34:26 UTC 
Created attachment 347036 [details] [review]
patch for review #1
Comment 2 Richard Hughes 2017-03-02 09:34:38 UTC 
Created attachment 347037 [details] [review]
patch for review #2
Comment 3 Richard Hughes 2017-03-02 09:34:49 UTC 
Created attachment 347038 [details] [review]
patch for review #3
Comment 4 Richard Hughes 2017-03-02 09:35:01 UTC 
Created attachment 347039 [details] [review]
patch for review #4
Comment 5 Marc-Andre Lureau 2017-03-03 08:39:25 UTC 
LGTM, thanks