After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779435 - telepathyClient: Use a single update for text and timestamp
telepathyClient: Use a single update for text and timestamp
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-01 19:18 UTC by Florian Müllner
Modified: 2017-03-01 19:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
telepathyClient: Use a single update for text and timestamp (2.01 KB, patch)
2017-03-01 19:18 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-03-01 19:18:26 UTC 
Meh, I messed up - see patch.
Comment 1 Florian Müllner 2017-03-01 19:18:34 UTC 
Created attachment 346991 [details] [review]
telepathyClient: Use a single update for text and timestamp

Commit c6f22826cf added a call to update() to refresh the notification
time for sent and received messages. However as it omits the bannerMarkup
parameter, escaped text like ''' now makes it through verbatim.
Rather than adding the parameter, we can just refresh the timestamp in
the existing update() call to fix the issue - it means the notification
timestamp is only refreshed for received messages, but that reflects
the text shown in the notification, which isn't updated for sent
messages either.
Comment 2 Rui Matos 2017-03-01 19:38:34 UTC 
Review of attachment 346991 [details] [review]:

ok
Comment 3 Florian Müllner 2017-03-01 19:49:32 UTC 
Attachment 346991 [details] pushed as 645aa01 - telepathyClient: Use a single update for text and timestamp