After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779412 - gjs 1.47.91 configure fails with Fedora's mozjs38
gjs 1.47.91 configure fails with Fedora's mozjs38
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Philip Chimento
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-01 11:47 UTC by Kalev Lember
Modified: 2017-03-01 22:03 UTC
See Also:
GNOME target: 3.24
GNOME version: ---


Attachments
tests: Test explicitly for Intl API (1.07 KB, patch)
2017-03-01 19:37 UTC, Philip Chimento
committed Details | Review

Description Kalev Lember 2017-03-01 11:47:14 UTC
gjs 1.47.91 configure has a new check to detect whether mozjs was built with the intl api. For this test, it tries to execute a script with the standalone interpreter, /usr/bin/js or /usr/bin/js38.

However, Fedora's mozjs38 only includes the library and not the standalone interpreter, making it impossible to build gjs. Would it possible to drop this configure check, please?
Comment 1 Philip Chimento 2017-03-01 19:00:15 UTC
Sure. I have recently learned from upstream that the standalone js interpreter is not really meant to be distributed in the first place. So I can definitely remove the check.

I really would like to check this at build time, but I don't see any other way. Do you?
Comment 2 Philip Chimento 2017-03-01 19:37:18 UTC
Created attachment 346992 [details] [review]
tests: Test explicitly for Intl API

This should at least make it more clear what is going on if these tests
fail, and what the fix is: compile the Intl API into SpiderMonkey.

A build-time check would be preferred, but that is not possible; see bug
report.
Comment 3 Philip Chimento 2017-03-01 19:38:29 UTC
I reverted the configure check. This patch will hopefully make it more clear what the problem is if you have built mozjs without the Intl API, but unfortunately it's not a configure-time check.
Comment 4 Cosimo Cecchi 2017-03-01 20:34:46 UTC
Review of attachment 346992 [details] [review]:

Makes sense.
Comment 5 Kalev Lember 2017-03-01 21:26:30 UTC
Excellent, thanks!
Comment 6 Jeremy Bicha 2017-03-01 21:52:47 UTC
(In reply to Philip Chimento from comment #1)
> Sure. I have recently learned from upstream that the standalone js
> interpreter is not really meant to be distributed in the first place. So I
> can definitely remove the check.

Do you have a reference for not distributing the js binary?
Comment 7 Philip Chimento 2017-03-01 22:03:39 UTC
(In reply to Jeremy Bicha from comment #6)
> Do you have a reference for not distributing the js binary?

From here: https://bugzilla.mozilla.org/show_bug.cgi?id=1339931#c9