GNOME Bugzilla – Bug 779405
Fix librsvg tarball builds (in particular Windows builds)
Last modified: 2017-12-13 18:26:57 UTC
Hi, It seems that during the course of development two things came into the librsvg sources, that led to release tarballs not to build: -Added Rust sources that were not dist'ed. -Use of Pango-FT2, which is an optional component for Windows (unlike *NIX) I will post patches to address these issues. With blessings, thank you!
Created attachment 346958 [details] [review] Makefile.am: Dist the newly-added Rust sources Hi, This dist's the newly-added Rust sources that were added into the source tree...
Created attachment 347115 [details] [review] build: Check for PangoFT2 and FontConfig Hi, This updates the build files and the sources to check for the presence of PangoFT2 and FontConig, and so: -On Windows, only build the portions used by the tests to use PangoFT2 and FontConfig when PangoFT2 and FontConfig are found (or enabled in Visual Studio builds--which is disabled by default, as the GTK+ stack uses PangoWin32 and the Windows API to do font discovery and manipulation by default). We may need to investigate later how to load the custom .ttf using PangoWin32 and/or Win32 APIs only on Windows. -On non-Windows, bail out the configure/build when PangoFT2 or FontConfig is not found. With blessings, thank you!
Created attachment 347117 [details] [review] build: Check for PangoFT2 and FontConfig (take ii) Hi, Attaching a new version of the patch since we need to include config.h in the sources that include rsvg-cairo-render.h so that HAVE_PANGOFT2 can be checked properly during the compilation process. We might be able to do this in rsvg-cairo-render.h, but since we already include config.h in rsvg-base.c, I think I should leave it this way as I am not sure whether it is used for other things as well in there. With blessings, thank you!
I'm fine with this patch; please commit it :) Do you know if there's a way we could get reproducible font rendering on Windows so that "make check" can work there?
Created attachment 357228 [details] [review] configure.ac: Remove extra check on PangoFT2 Hi Federico, Thanks, I pushed the patch in there as 46c8688. I realized that very recently a check for PangoFT2 was added, which my patch covered IMO, so this is another patch to just use the check I added in my patch. Sorry for the noise, and if I am mistaken, because I am not that good in autotools at any point :). For making the test on Windoows without FontConfig, I will try to look into it, which will likely involve using the Windows APIs to load the TTF and to force the use of it. With blessings, thank you!
Thanks for fixing this, and sorry for the mid-flight collision with my changes for OS X :-P Feel free to close this bug if you think it's finished - making the tests work on Windows can go in another bug. I've just added you to the librsvg_developers group in Bugzilla so you can do that - I have no idea why you were not already there.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/librsvg/issues/163.