After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779378 - devhelp 3.23.91 fails to build because of -Werror
devhelp 3.23.91 fails to build because of -Werror
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
3.23.x
Other Linux
: Normal major
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-28 19:00 UTC by Jeremy Bicha
Modified: 2017-03-01 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jeremy Bicha 2017-02-28 19:00:55 UTC
devhelp 3.23.91 fails to build from source on Ubuntu 17.04.

hughsie and DimStar also mentioned this issue today in #gnome-hackers (so that's Fedora and openSUSE?)

I think the problem are these 2 lines in configure.ac
AX_REQUIRE_DEFINED([AX_IS_RELEASE])
AX_IS_RELEASE([git-directory])

Although --disable-Werror is set in Makefile.am, it was ignored or overriden when the tarball was generated. It makes sense for the maintainer to produce the tarball from git so those configure.ac flags are a problem.

https://www.gnu.org/software/autoconf-archive/ax_is_release.html


Workaround
----------
Run autoreconf and pass --disable-Werror to configure
Comment 1 Sébastien Wilmet 2017-02-28 20:53:35 UTC
Thanks for the bug report, it was worthwhile to do a tarball before 3.24.0.

--disable-Werror is not needed to build other GNOME modules from tarballs (and where deprecation warnings are present). So there must be something wrong in the Devhelp build system.

I will try to fix this for 3.23.92.
Comment 2 Jeremy Bicha 2017-02-28 22:07:34 UTC
(In reply to Sébastien Wilmet from comment #1)
> Thanks for the bug report, it was worthwhile to do a tarball before 3.24.0.

It would be nice to at least do a .90 release next time if you are doing any bigger changes. I think that would make Ubuntu's Release Team happier since Ubuntu's Feature Freeze tends to be immediately after GNOME's Freeze.

Thanks!
Comment 3 Sébastien Wilmet 2017-03-01 12:35:28 UTC
Fixed:
commit 3a53909ca3869005aeceb3f13c88da930b818a3a
commit 8abfbb59653d0b2e12f9b38a4b616de7756cce53

`make distcheck` passes fine without --disable-Werror, and I've tested `./configure && make` after extracting the tarball, it works fine.

So for 3.23.92 it'll be fixed.
Comment 4 Jeremy Bicha 2017-03-01 13:28:41 UTC
Thanks, I confirm that the first commit fixes this bug.