GNOME Bugzilla – Bug 779359
IdeDiagnostic: set the location from range when unset
Last modified: 2017-02-28 21:52:29 UTC
The gnome code assistance plugin creates an IdeDiagnostic object with no location, and then sets one or more IdeSourceRange's on it. We can assume that the first source range corresponds to where the problem is, and set the location based on it. Without a location, the diagnostic will be dropped on the floor, which is not nice.
Created attachment 346888 [details] [review] IdeDiagnostic: set the location from range when unset
Review of attachment 346888 [details] [review]: LGTM, thanks!
Attachment 346888 [details] pushed as 4b2bf5a - IdeDiagnostic: set the location from range when unset