After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779336 - String question for night light
String question for night light
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: color
3.23.x
Other Linux
: Normal minor
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2017-02-27 21:04 UTC by Anders Jonsson
Modified: 2018-06-05 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
at present times -> at the present time (1.21 KB, patch)
2017-07-12 22:52 UTC, Anders Jonsson 		none Details | Review
present times -> preset times (1.21 KB, patch)
2017-11-07 16:36 UTC, Anders Jonsson 		none Details | Review

Description Anders Jonsson 2017-02-27 21:04:04 UTC 
In data/org.gnome.settings-daemon.plugins.color.gschema.xml.in.in is the string:


"Night light mode changes the color temperature of your display when the sun has gone down or at present times."


Here "present times" looks strange to me. There is just one present time. Is this meant to be "at preset times" or "at the present time"?
Comment 1 Michael Catanzaro 2017-07-12 01:27:19 UTC 
"at the present time"
Comment 2 Anders Jonsson 2017-07-12 22:52:10 UTC 
Created attachment 355470 [details] [review]
at present times -> at the present time
Comment 3 Alexandre Franke 2017-10-02 20:50:55 UTC 
(In reply to Michael Catanzaro from comment #1)
> "at the present time"

Given the context, I’m pretty sure this is wrong and it should be "at preset times".
Comment 4 Michael Catanzaro 2017-10-03 09:50:29 UTC 
Yes, good point. The English string is wrong.
Comment 5 Anders Jonsson 2017-11-07 16:36:47 UTC 
Created attachment 363160 [details] [review]
present times -> preset times

(In reply to Michael Catanzaro from comment #4)
> Yes, good point. The English string is wrong.

Ok, here we go with a revised patch...
Comment 6 Benjamin Berg 2018-06-05 13:32:45 UTC 
I added it into MR 21:
  https://gitlab.gnome.org/GNOME/gnome-settings-daemon/merge_requests/21

Lets assume it will go into master soon and tracking there is sufficient. Thanks for the patch!