After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779316 - grss_feeds_group_export_file should overwrite existing file
grss_feeds_group_export_file should overwrite existing file
Status: RESOLVED FIXED
Product: libgrss
Classification: Other
Component: General
0.7.x
Other Linux
: Normal normal
: ---
Assigned To: Libgrss Maintainers
Libgrss Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-27 15:09 UTC by Felipe Borges
Modified: 2017-02-27 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
feeds-group: Overwrite export file destination (973 bytes, patch)
2017-02-27 15:09 UTC, Felipe Borges
committed Details | Review
feeds-group: Fix typos at _export_file doc text (1.07 KB, patch)
2017-02-27 15:13 UTC, Felipe Borges
committed Details | Review

Description Felipe Borges 2017-02-27 15:09:05 UTC
According to the API docs for grss_feeds_group_export_file ():

"Creates a new file with the list of channels rappresented in the required format. It a file already exists at the uri location, it is overwritten."

But when I try to use the method, my file ends up appended by the FeedChannels list.
Comment 1 Felipe Borges 2017-02-27 15:09:29 UTC
Created attachment 346827 [details] [review]
feeds-group: Overwrite export file destination

grss_feeds_group_export_file should overwrite existing file, instead
of appending the FeedsChannel list to it.
Comment 2 Felipe Borges 2017-02-27 15:13:46 UTC
Created attachment 346828 [details] [review]
feeds-group: Fix typos at _export_file doc text
Comment 3 Igor Gnatenko 2017-02-27 20:31:40 UTC
Review of attachment 346827 [details] [review]:

lgtm
Comment 4 Igor Gnatenko 2017-02-27 20:31:49 UTC
Review of attachment 346828 [details] [review]:

lgtm
Comment 5 Felipe Borges 2017-02-27 20:56:47 UTC
Thank you Igor!

Attachment 346827 [details] pushed as 2f637c4 - feeds-group: Overwrite export file destination
Attachment 346828 [details] pushed as 971c421 - feeds-group: Fix typos at _export_file doc text