After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779303 - omnibar: use symbolic icon of dialog-warning
omnibar: use symbolic icon of dialog-warning
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-27 10:00 UTC by Mohammed Sadiq
Modified: 2017-02-28 00:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omnibar: use symbolic icon of dialog-warning (985 bytes, patch)
2017-02-27 10:00 UTC, Mohammed Sadiq 		none Details | Review
omnibar: use colored dialog-warning-symbolic icon (1.54 KB, patch)
2017-02-27 17:13 UTC, Mohammed Sadiq 		none Details | Review
omnibar: use colored dialog-warning-symbolic icon (1.63 KB, patch)
2017-02-27 17:28 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2017-02-27 10:00:27 UTC 
.
Comment 1 Mohammed Sadiq 2017-02-27 10:00:36 UTC 
Created attachment 346803 [details] [review]
omnibar: use symbolic icon of dialog-warning
Comment 2 Christian Hergert 2017-02-27 10:12:25 UTC 
Non-symbolic was chosen on purpose to match the designs.
Comment 3 Mohammed Sadiq 2017-02-27 17:13:06 UTC 
Created attachment 346838 [details] [review]
omnibar: use colored dialog-warning-symbolic icon
Comment 4 Mohammed Sadiq 2017-02-27 17:28:10 UTC 
Created attachment 346845 [details] [review]
omnibar: use colored dialog-warning-symbolic icon

Replace the dialog-warning icon with symbolic icon,
and add a warning style to match the design.
Comment 5 Christian Hergert 2017-02-27 18:04:57 UTC 
Review of attachment 346845 [details] [review]:

LGTM, thanks for catching the detail here